Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: added unit test for getGPUSKU #525

Merged
merged 1 commit into from
Apr 10, 2023
Merged

test: added unit test for getGPUSKU #525

merged 1 commit into from
Apr 10, 2023

Conversation

smritidahal653
Copy link
Collaborator

added unit test for getGPUSKU in aci.go. Fixed error message to use the right values.

@smritidahal653 smritidahal653 temporarily deployed to test April 10, 2023 22:30 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 temporarily deployed to test April 10, 2023 22:30 — with GitHub Actions Inactive
@smritidahal653 smritidahal653 mentioned this pull request Apr 10, 2023
Closed
8 tasks
@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Apr 10, 2023

LGTM

helayoty
helayoty approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@helayoty helayoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helayoty helayoty merged commit c88ad2e into virtual-kubelet:master Apr 10, 2023
@smritidahal653 smritidahal653 deleted the unitTestCoverage branch April 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helayoty helayoty helayoty approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

Assignees
No one assigned
Labels
kind/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smritidahal653 @Fei-Guo @helayoty