Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for security context properties #542

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: added support for security context properties #542

wants to merge 10 commits into from

Conversation

fnuarnav
Copy link
Collaborator

@fnuarnav fnuarnav commented May 3, 2023

No description provided.

@fnuarnav fnuarnav temporarily deployed to test May 3, 2023 23:33 — with GitHub Actions Inactive
@fnuarnav fnuarnav marked this pull request as draft May 3, 2023 23:33
@fnuarnav fnuarnav temporarily deployed to test May 3, 2023 23:33 — with GitHub Actions Inactive
@fnuarnav fnuarnav changed the title added support for security context properties feat: added support for security context properties May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023 •
edited
Loading

Codecov Report

Merging #542 (c6bf8ca) into master (50c56a0) will increase coverage by 0.55%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   69.81%   70.36%   +0.55%     
==========================================
  Files          15       16       +1     
  Lines        2597     2666      +69     
==========================================
+ Hits         1813     1876      +63     
- Misses        666      670       +4     
- Partials      118      120       +2
Impacted Files Coverage Δ
pkg/provider/aci.go 69.88% <68.42%> (-0.77%) ⬇️
pkg/provider/aci_confidential.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 16:20 — with GitHub Actions Inactive
helayoty
helayoty reviewed May 4, 2023
View reviewed changes
pkg/provider/aci.go Outdated Show resolved Hide resolved
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:11 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:12 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:27 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:27 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:36 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 4, 2023 19:36 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test May 10, 2023 04:54 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test June 12, 2023 16:24 — with GitHub Actions Inactive
@fnuarnav fnuarnav marked this pull request as ready for review June 12, 2023 18:24
@fnuarnav fnuarnav temporarily deployed to test June 13, 2023 20:45 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test June 13, 2023 23:18 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test June 13, 2023 23:50 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test June 13, 2023 23:50 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test July 19, 2023 20:03 — with GitHub Actions Inactive
@fnuarnav fnuarnav requested a review from helayoty July 19, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

@smritidahal653 smritidahal653 Awaiting requested review from smritidahal653 smritidahal653 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fnuarnav @helayoty