export node's IP addresses as env vars #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uncovered a heap of stuff that wasn't done properly, hence the size of the PR. This adds 2 new flags --node-ip and --node-external-ip, which override whatever we find ourselves. We also set this on node object. And we export these as SYSTEMK_NODE_INTERNAL_IP and SYSTEMK_NODE_EXTERNAL_IP (unclear if we keep this though, looks handy though). Next I want to test this setup with Prometheus rewriting targets based on these values. The step after that is using CoreDNS which binds the metrics to the internal IP address by using the SYSTEMK_NODE_INTERNAL_IP env var. We also fix the environment settings for the API server host and port. We do require a kubeconfig to be given and should probably fatal if not seen. Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uncovered a heap of stuff that wasn't done properly, hence the size
of the PR.
This adds 2 new flags --node-ip and --node-external-ip, which override
whatever we find ourselves. We also set this on node object. And we
export these as SYSTEMK_NODE_INTERNAL_IP and SYSTEMK_NODE_EXTERNAL_IP
(unclear if we keep this though, looks handy though). Next I want to
test this setup with Prometheus rewriting targets based on these values.
The step after that is using CoreDNS which binds the metrics to the
internal IP address by using the SYSTEMK_NODE_INTERNAL_IP env var.
Signed-off-by: Miek Gieben miek@miek.nl