node: support following logs #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final step to fix virtual-kubelet#5 Signed-off-by: Pires <pjpires@gmail.com>
|
PRs with screen recording should be merged without review IMO |
|
I can't tell if that's a rant or a praise :D Since we have no tests, I just wanted to show the feature working, and also share my enthusiasm of getting it to work. |
miekg
approved these changes
Jan 22, 2021
|
can't image testing this to be easy... maybe cut and paste kubelet tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step to fix #5
Screen.Recording.2021-01-22.at.16.13.13.mov