Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Adding Timeout in cache.WaitForCacheSync #594

Closed
sargun opened this issue May 3, 2019 · 3 comments
Closed

Consider Adding Timeout in cache.WaitForCacheSync #594

sargun opened this issue May 3, 2019 · 3 comments

Comments

@sargun
Copy link
Contributor

sargun commented May 3, 2019

This can last forever:

if ok := cache.WaitForCacheSync(ctx.Done(), pc.podsInformer.Informer().HasSynced); !ok {
return pkgerrors.New("failed to wait for caches to sync")
}

The node will show up, and continue to heartbeat, but never get back into sync. I suggest two things:

  1. That the node doesn't show up as up until this completes
  2. We add a timeout here that's reasonable, or configurable.
@sargun
Copy link
Contributor Author

sargun commented May 3, 2019

See: #597

@sargun
Copy link
Contributor Author

sargun commented May 6, 2019

Fixed!

@sargun sargun closed this as completed May 6, 2019
@srinat999
Copy link

Hi. I'm facing this issue too. What was the solution at the end? I tried using --startup-timeout option, but the startup just exits once the timeout has reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants