Add the /runningpods/ api endpoint #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tracing to the testing to get the kubelet's logs upon failure. In addition, it keeps track of the pods, and the node statuses throughout the test.
sargun
force-pushed
the
add-running-pods-endpoint
branch
from
c613524
to
cceb51d
Compare
sargun
commented
May 9, 2019
vkubelet/api/pods.go
Outdated
| ctx = log.WithLogger(ctx, log.L) | ||
| pods, err := p.GetPods(ctx) | ||
| if err != nil { | ||
| return strongerrors.System(err) |
There was a problem hiding this comment.
@cpuguy83 No idea if this is the right one to use.
There was a problem hiding this comment.
The provider should give the correct error rather than try to figure it out here.
There was a problem hiding this comment.
Will handlError handle it correctly if they don't return a strongerror?
sargun
force-pushed
the
add-running-pods-endpoint
branch
from
cceb51d
to
0ba2881
Compare
This adds an API endpoint from the kubelet (/runningpods/). It is an endpoint on kubelet which is considered a "debug" endpoint, so it might be worth exposing through the options, but by default it is exposed in most k8s configs AFAICT.
sargun
force-pushed
the
add-running-pods-endpoint
branch
from
0ba2881
to
10c44e7
Compare
|
@cpuguy83 any opinions? |
hongbin
pushed a commit
to hongbin/virtual-kubelet
that referenced
this pull request
May 18, 2020
* Add the /runningpods/ api endpoint This adds an API endpoint from the kubelet (/runningpods/). It is an endpoint on kubelet which is considered a "debug" endpoint, so it might be worth exposing through the options, but by default it is exposed in most k8s configs AFAICT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an API endpoint from the kubelet (/runningpods/). It is
an endpoint on kubelet which is considered a "debug" endpoint, so
it might be worth exposing through the options, but by default
it is exposed in most k8s configs AFAICT.