Add /pods HTTP endpoint #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sargun
force-pushed
the
add-pods-api
branch
2 times, most recently
from
ac28b8d
to
21e8f10
Compare
cpuguy83
reviewed
Mar 20, 2020
node/api/server.go
Outdated
| @@ -36,7 +36,8 @@ type ServeMux interface { | |||
| type PodHandlerConfig struct { | |||
| RunInContainer ContainerExecHandlerFunc | |||
| GetContainerLogs ContainerLogsHandlerFunc | |||
| GetPods PodListerFunc | |||
| GetPodsFromProvider PodListerFunc | |||
There was a problem hiding this comment.
I don't think we should change the name of this field. Maybe add a doc string?
sargun
force-pushed
the
add-pods-api
branch
2 times, most recently
from
b02e587
to
73b7568
Compare
|
Still working on this PR. I'll ask for re-review once things are ready. |
sargun
force-pushed
the
add-pods-api
branch
4 times, most recently
from
bf3c528
to
b0f7704
Compare
|
@cpuguy83 I made it so we just re-use the podlister that the resource manager has. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.