Add parameters to support change work queue #841
Conversation
|
tests seem unhappy since #834 merged |
node/podcontroller.go
Outdated
| @@ -198,8 +217,9 @@ func NewPodController(cfg PodControllerConfig) (*PodController, error) { | |||
| ready: make(chan struct{}), | |||
| done: make(chan struct{}), | |||
| recorder: cfg.EventRecorder, | |||
| k8sQ: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "syncPodsFromKubernetes"), | |||
| deletionQ: workqueue.NewNamedRateLimitingQueue(workqueue.DefaultControllerRateLimiter(), "deletePodsFromKubernetes"), | |||
| k8sQ: workqueue.NewNamedRateLimitingQueue(controllerRateLimiter(cfg.WorkQueueRetryQPS), "syncPodsFromKubernetes"), | |||
There was a problem hiding this comment.
Were the previous defaults 10?
There was a problem hiding this comment.
Yeap, it is defined 10 in the original client-go
There was a problem hiding this comment.
btw, what do you recommend?
In our environment, we have changed it to 100 now to accelerate deleting pods.
|
tests should be fixed by #842 -- the problem is that K8s just release 1.17.7. This broke the validation script. |
cwdsuzhou
force-pushed
the
June/support_queue_define
branch
from
109fa8a
to
b534925
Compare
|
btw, what do you recommend? |
|
Before this works, we should wait for the PR virtual-kubelet/node-cli#22 in node-cli to be merged |
|
@cwdsuzhou I'll hold off on the merge. But, this to me looks like it should work, and fallback to 10. |
|
Currently we do not expose anything about the queue, or even that we use a queue to the package API. This changes that. |
|
I wonder if it would be better to expose the queue to the config instead of the queue config. |
yes, this should work |
This is better. But I prefer to exposing the |
cwdsuzhou
force-pushed
the
June/support_queue_define
branch
from
d7e3d4a
to
8df7338
Compare
cwdsuzhou
force-pushed
the
June/support_queue_define
branch
from
8df7338
to
b8ac627
Compare
cwdsuzhou
force-pushed
the
June/support_queue_define
branch
from
b8ac627
to
ca417d5
Compare
cwdsuzhou
changed the title
I will close virtual-kubelet/node-cli#22 and re-open a new one when this PR has been merged. |
|
@cpuguy83 Are you okay with this, or do you want to take a different approach of queue / queue configuration / queue configuration policy? |
Fix #840