Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation to node controller (tracing) #846

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Add instrumentation to node controller (tracing) #846

merged 1 commit into from
Jul 1, 2020

Conversation

sargun
Copy link
Contributor

@sargun sargun commented Jul 1, 2020

This adds tracing in node controller in several sections where
it was missing.

@sargun
Add instrumentation to node controller (tracing)
30aabe6 
This adds tracing in node controller in several sections where
it was missing.
@sargun sargun requested a review from cpuguy83 July 1, 2020 19:47
cpuguy83
cpuguy83 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit 5306173 into virtual-kubelet:master Jul 1, 2020
@sargun sargun deleted the add-trace-to-updateStatus branch July 1, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuguy83 cpuguy83 cpuguy83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sargun @cpuguy83