Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix running pods handler on nil lister #852

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Fix running pods handler on nil lister #852

merged 1 commit into from
Jul 15, 2020

Conversation

cpuguy83
Copy link
Contributor

This follows suit with other hanlders and returns a NotImplemented
http.HandlerFunc when the lister is nil.

@cpuguy83
Fix running pods handler on nil lister
bcb5dfa 
This follows suit with other hanlders and returns a NotImplemented
http.HandlerFunc when the lister is nil.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@cpuguy83 cpuguy83 requested a review from ldx July 14, 2020 22:36
@cpuguy83 cpuguy83 mentioned this pull request Jul 14, 2020
Closed
ldx
ldx approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@ldx ldx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for looking into this 👍

@cpuguy83 cpuguy83 merged commit ee7f5fa into virtual-kubelet:master Jul 15, 2020
@cpuguy83 cpuguy83 deleted the fix_running_pods_npe branch July 30, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldx ldx ldx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpuguy83 @ldx