Skip to content
This repository has been archived by the owner on Oct 4, 2022. It is now read-only.

subject pool: start date / end date bug #81

Closed
alee opened this issue Feb 11, 2015 · 4 comments
Closed

subject pool: start date / end date bug #81

alee opened this issue Feb 11, 2015 · 4 comments
Assignees
Labels

Comments

@alee
Copy link
Member

alee commented Feb 11, 2015

start date and end date logic is still bugged, trying to save a session with an end date one hour after the start date brings up the validation error alert.

@alee alee added the bug label Feb 11, 2015
@alee
Copy link
Member Author

alee commented Feb 11, 2015

Looks like session.end_date() isn't getting set by KO properly

@tgpatel
Copy link
Contributor

tgpatel commented Feb 11, 2015

hmm.. I'm not able to reproduce the issue and I don't see an alert. But I did observe that the change in date is not reflected on observable fields start_date and end_date and hence change of date doesn't work.

@tgpatel
Copy link
Contributor

tgpatel commented Feb 11, 2015

I was able to reproduce the issue. It happens only for newly created sessions. But the issue I believe is same as you mentioned and I mentioned in my previous comment.

@alee
Copy link
Member Author

alee commented Feb 11, 2015

I think the KO binding may be buggy. Can you look at Eonasdan/tempus-dominus#219 and see if the implementation by yoanisgil will fix things?

Please set the initial start date and end date to sane values at the beginning in model.addSession as well, something like

var initial_start_date = moment().add(1, 'days').hour(10).minute(0).format('YYYY-MM-DD HH:mm');
var initial_end_date = moment().add(1, 'days').hour(11).minute(0).format('YYYY-MM-DD HH:mm');
model.session_list.push(new SessionModel({..}))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants