Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualmin modify-php-ini - some changes to the description #801

Closed
shoulders opened this issue May 3, 2024 · 1 comment
Closed

virtualmin modify-php-ini - some changes to the description #801

shoulders opened this issue May 3, 2024 · 1 comment

Comments

@shoulders
Copy link

shoulders commented May 3, 2024

SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.4
Webmin version 2.111
Usermin version 2.010
Virtualmin version 7.10.0  
Theme version 21.10
Package updates 3 package updates are available

The background

virtualmin help modify-php-ini

960539e4e3f2b345a7ec9700e1a60a5bff7956a2

The issue

This command can be used to change the value of a PHP configuration
variable (set in the php.ini file and Apache configuration) for one or
many virtual servers at once.

This refers to php.ini and Apache configuration and their are a few things wrong with this statement

  • I am not sure that the Apache configuration is altered by this command. it might be a relic from the mod_php days.
  • This command now alters .conf files for the the PHP-FPM service

Proposed solution

Can you make some changes to the description for the following points

  • (set in the php.ini file and Apache configuration)
    -->
    (set in the php.ini file and FPM .conf files)
  • This does not change the global php.ini.
    • If this is an obvious point, please ignore.

Additional

@jcameron
Copy link
Collaborator

jcameron commented May 3, 2024

Thanks, I'll update the help text to make it clearer what this command modifies. It will still update the Apache config if mod_php is in use though.

webmin pushed a commit that referenced this issue May 3, 2024
@jcameron jcameron closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants