Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build stable on version change and in virtualmin repo #10

Merged
merged 11 commits into from Jul 10, 2023

Conversation

swelljoe
Copy link
Collaborator

Hopefully, this will make the following changes:

  1. Only build stable packages if the module.info has changed (hopefully indicating someone remembered to bump the version).
  2. Removes date string from the stable package version (since we will hopefully always have a new human selected version).
  3. Only build packages if it's on the virtualmin repo, not forks. Tests still run on forks, so people can see if they've made a silly mistake, like syntax errors. Forks shouldn't have valid secrets for our repos, so even if it builds on a fork it can't actually publish, but no reason to chew CPU cycles for nothing.
  4. Fixes some problems with publishing (permissions and ownership), so the build server user can operate on files created by the actions user.
  5. Changes the publish queue path to be the full file path. The publisher splits it at run time so it can both sign the package with the right key for each repo, and publish any repos with changes.

Hopefully this is the last of the bits needed before I start replicating this out to all Virtualmin module repos.

@swelljoe swelljoe merged commit bb5ee8c into virtualmin:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant