Feature/463 multiple users per discipline #1172

DimitriDiantos · 2023-09-26T12:33:27Z

To enable the storage of multiple users, follow these steps:

Modify the addButtonSelectionListeners method, createTableColumns method, and the EListStringCellEditingSupport class that extends EStringCellEditingSupport within the UiSnippetRoleManagement class.

add the CustomDialog, which is a custom dialog that extends the Dialog class, allowing user interaction to modify a list of users.

The dialog provides options to add, remove, update, and rearrange users in the list. It also notifies the parent application
of user changes using a callback mechanism.
This dialog is primarily used to interact with and manage a list of features displayed to the user, enabling them to make necessary modifications.
This dialog includes the following features:
- Adding a new feature to the list
- Removing an existing feature from the list
- Updating an existing feature in the list
- Moving a feature up or down in the list
The dialog is configured to have a specified size and is centered on the screen for user convenience.
Usage:
1. Create an instance of CustomDialog, providing the parent shell, initial features to display, and a callback for feature updates.
1. Open the dialog using the open() method.

Correct any errors resulting from the modifications made in the DVLM.Ecore model. Specifically, replace the cardinality of 1 with -1 for the user in the Discipline table.

- by modifying the method addButtonSelectionListeners, createTableColumns and the class EListStringCellEditingSupport which extends EStringCellEditingSupport from the class UiSnippetRoleManagement. -by adding the method setUser inside the Discipline class - by implementing the method setUser in the class DisciplineImpl

- by modifying the method addButtonSelectionListeners, createTableColumns and the class EListStringCellEditingSupport which extends EStringCellEditingSupport from the class UiSnippetRoleManagement. -by adding the method setUser inside the Discipline class - by implementing the method setUser in the class DisciplineImpl - by updating the RightsHelper class to handle the list of users for a discipline. -by setting the list of users accordingly, when creating a new discipline in the class UiSnippetRoleManagement

Modify the addButtonSelectionListeners method, createTableColumns method, and the EListStringCellEditingSupport class that extends EStringCellEditingSupport within the UiSnippetRoleManagement class. Correct any errors resulting from the modifications made in the DVLM.Ecore model. Specifically, replace the cardinality of 1 with -1 for the user in the Discipline table.

to handle the adding of new user in the Discipline.

Doing it for the clarity of the right syntax to adopt during the add of a new user in the list of user.

ElistStringCellEditingSupport class, update of the UiSnippetRoleManagement class and creating of the FeatureUpdateCallback interface.

discipline Implement the CustomDialog class, extending the Dialog class to create a custom dialog that allows user interaction to modify a list of users for a discipline. The dialog provides functionality to add, remove, update, move up, and move down users in the list. Additionally, an interface FeatureUpdateCallback is defined to handle feature update callbacks. Also, introduce EListStringCellEditingSupport to handle cell editing in a table viewer for EList of strings in the context of editing a Discipline. Files affected: - CustomDialog.java (new created file) - FeatureUpdateCallback.java(new created file) - EListStringCellEditingSupport.java (new created file) - UiSnippetRoleManagement.java (exited file before the custom Dialog) - EStringCellEditingSupport (existing before)

DimitriDiantos · 2023-10-10T10:39:19Z

franzTobiasDLR

Wow, pretty cool! I really like your changes! Also how you documented your code 👍 I think I found some minor things you could improve... The most importand thing is to make sure you only comited those changes you actually did on purpose... :)

de.dlr.sc.virsat.model.extension.requirements/concept/concept_v0_7.xmi

...src/de/dlr/sc/virsat/uiengine/ui/cellEditor/emfattributes/EListStringCellEditingSupport.java

...irsat.uiengine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/CustomDialog.java

...ine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/UiSnippetRoleManagement.java

franzTobiasDLR · 2023-11-23T08:58:40Z

Nice, now there is the green arrow 👍 🚀

dellerDLR · 2023-11-29T17:02:21Z

de.dlr.sc.virsat.model/model/dvlm.ecore

@@ -155,8 +155,8 @@
      </eAnnotations>
    </eClassifiers>
    <eClassifiers xsi:type="ecore:EClass" name="EcoreImport">
-      <eStructuralFeatures xsi:type="ecore:EAttribute" name="importedNsURI" eType="ecore:EDataType platform:/plugin/org.eclipse.emf.ecore/model/Ecore.ecore#//EString"/>
-      <eStructuralFeatures xsi:type="ecore:EAttribute" name="importedGenModel" eType="ecore:EDataType platform:/plugin/org.eclipse.emf.ecore/model/Ecore.ecore#//EString"/>
+      <eStructuralFeatures xsi:type="ecore:EAttribute" name="importedNsURI" eType="ecore:EDataType ../../org.eclipse.emf.ecore/model/Ecore.ecore#//EString"/>


Does the change from platform:/plugin to ../.. have some implications? @franzTobiasDLR

No, the difference is just weather you have the dependency in you local worksapce or in the target plattform cache... It will switch automatically... As far as I know we don't have a polixy what to commit.

I talked with @pchrszon-dlr and we think that the change should be reverted sothat no change shows up in the history

dellerDLR · 2023-11-29T17:07:20Z

de.dlr.sc.virsat.apps.test/src/de/dlr/sc/virsat/apps/api/external/ModelAPIAppsTest.java

+        assertTrue("Discipline should be added to Disciplines", repository.getRoleManagement().getDisciplines().contains(discipline));
+
+        // Verify that the user is added to the Discipline
+        assertTrue("User should not be added to Discipline", discipline.getUsers().contains("SampleUser"));


I think the "not" can be removed in the string?

I think the "not" can be removed in the string?

Thanks 👍. I removed the "not".

dellerDLR · 2023-12-06T09:08:44Z

On small screens not all buttons are visible and the size of the window cannot be adjusted. As a result the Down Button is not visible:

Ah nice usability feature would be, if the add button is in focus. Then it would be easier to add multiple users in a short time.

Also I think "users" should be capatilized, since it is a heading.

@DimitriDiantos Despite that it the pull request looks good and can be merged from my side :)

dellerDLR · 2023-12-06T09:12:00Z

Could you also increase the size of the column? Otherwise only one name is displayed if you dont increase the size manually.

dellerDLR · 2023-12-06T09:19:26Z

I also noticed that the header if you try to add a empty string as a user, displays a wrong error

DimitriDiantos · 2023-12-06T15:40:31Z

I also noticed that the header if you try to add a empty string as a user, displays a wrong error

Thank you for the feedback; I have already corrected it

DimitriDiantos · 2023-12-06T16:39:28Z

I also noticed that the header if you try to add a empty string as a user, displays a wrong error

Here below is the result:

DimitriDiantos · 2023-12-06T17:22:05Z

Could you also increase the size of the column? Otherwise only one name is displayed if you dont increase the size manually.

Thanks for you comment :). I fixed it. You can find below the result.

DimitriDiantos · 2023-12-06T18:01:37Z

the size of the window

I

fixed it.

of the dialog to "USERS_DISCIPLINE" increase the size of the window, so that all buttons are visible. Add the "add button" as focus.

dellerDLR · 2023-12-08T10:45:50Z

@DimitriDiantos Looks good. But I think you forgot to push the changes, right?

of the dialog to "USERS_DISCIPLINE" increase the size of the window, so that all buttons are visible. Add the "add button" as focus.

dellerDLR · 2023-12-14T15:34:49Z

The header of the error dialog has a grammar error.

Could you write the header of the main dialog not on caps (User Discipline)?

Despite that I didn't find any issues.
After that we can finally merge it :)

DimitriDiantos · 2023-12-14T16:01:49Z

The header of the error dialog has a grammar error.

Could you write the header of the main dialog not on caps (User Discipline)?

Despite that I didn't find any issues. After that we can finally merge it :)

Thanks for your comment. I already changed it. you can find below the result. :)

dellerDLR · 2023-12-14T16:14:55Z

Hey @DimitriDiantos ,
I just noticed that it is possible to edit the discipline names, even if I do not have the proper permissions.
I think there is a check missing before opening the dialog, if the user has the right to change the role management.

It is not saved on the disk, but may cause confusion.

As you can see, I can open the dialog, even though I do not have the permission to press the other buttons.

dellerDLR · 2023-12-14T16:24:16Z

I even managed to make me the system engineer, which gives me the right to change the system model

While doing this, the changes even get saved to the disk.

dellerDLR · 2023-12-14T16:25:40Z

You probably ahve to check the EditingSupport of the table.
Maybe tou forgot to use the RoleManagementCheck Command

DimitriDiantos · 2023-12-14T17:57:41Z

Hey @DimitriDiantos , I just noticed that it is possible to edit the discipline names, even if I do not have the proper permissions. I think there is a check missing before opening the dialog, if the user has the right to change the role management.

It is not saved on the disk, but may cause confusion.

As you can see, I can open the dialog, even though I do not have the permission to press the other buttons.

I fixed by adding a method to check, if the actual user belong to the list of users. else he cannot make a change. below you can find the screen of the result.

DimitriDiantos · 2023-12-14T18:03:44Z

Hey @DimitriDiantos , I just noticed that it is possible to edit the discipline names, even if I do not have the proper permissions. I think there is a check missing before opening the dialog, if the user has the right to change the role management.
It is not saved on the disk, but may cause confusion.

As you can see, I can open the dialog, even though I do not have the permission to press the other buttons.

I fixed by adding a method to check, if the actual user belong to the list of users. else he cannot make a change. below you can find the screen of the result. i also solved the problem for the refresh button. you can check it. :).

access can make modifications,and solving the refresh problem.

DimitriDiantos · 2023-12-15T08:55:20Z

Hi @franzTobiasDLR @dellerDLR Now the data is stored in the database and when you press the refresh button it always displays all the data.

...ine.ui/src/de/dlr/sc/virsat/uiengine/ui/editor/snippets/general/UiSnippetRoleManagement.java

ngat_di added 4 commits September 15, 2023 14:51

DimitriDiantos requested review from PhilMFischer, franzTobiasDLR and dellerDLR September 26, 2023 12:33

DimitriDiantos linked an issue Sep 26, 2023 that may be closed by this pull request

Multiple users per discipline #463

Closed

3 tasks

ngat_di added 5 commits September 26, 2023 17:07

update know_author file

325a61d

Task #463 creating of a new class EListStringCellEditingSupport

68ea324

to handle the adding of new user in the Discipline.

Task #463 Warning message for the user, when the delimiter is wrong.

2de9bd2

Doing it for the clarity of the right syntax to adopt during the add of a new user in the list of user.

Task #463 :creating of the CustomDialog class, updating of the

3f67318

ElistStringCellEditingSupport class, update of the UiSnippetRoleManagement class and creating of the FeatureUpdateCallback interface.

ngat_di added 3 commits October 10, 2023 15:19

Task #453 Updating of the BeanDisciplineTest class

92f1289

Task #463 update the CustomDialog constructor and the ModelAPI class

4049a2b

Task#463 Update of the BeanDisciplineTest

e4c5a4a

franzTobiasDLR reviewed Oct 16, 2023

View reviewed changes

ngat_di added 12 commits October 16, 2023 13:11

Task #463 Updating of the CustomerDialog class

aa85ca3

Task #463 Update of the RightsHelper and RightsHelperTest

254381a

Task #463 update

d1411ad

Task #463 update of the CustomDialog class

364d81b

Task #463 Update of RightsHelperTest class

e78e1b5

Task #463 update of the tests to the new API.

4a70aa5

Task #463 rename and move Dialog to the new package.

d866e6b

Task #463 handling for the Post of the server

8d05cf2

Task #463 Update of the BeanDisciplineTest.

e8d9032

Task #463 update serialization of the BeanDiscipline

21f4bd6

Task #463 reset the post of the BeanDisciplineTest

5f406ef

Task #463 migrate from the version 9 to 10.

905c532

dellerDLR reviewed Nov 29, 2023

View reviewed changes

Task #463 increase the size of the column "User Name", change the name

06666fa

of the dialog to "USERS_DISCIPLINE" increase the size of the window, so that all buttons are visible. Add the "add button" as focus.

Task #463 increase the size of the column "User Name", change the name

5c5d924

of the dialog to "USERS_DISCIPLINE" increase the size of the window, so that all buttons are visible. Add the "add button" as focus.

Task #463 Update the dialog's name and fix of the bug.

d9ebf28

Task #463 Access rights management, ensuring that only users with proper

c47456d

access can make modifications,and solving the refresh problem.

franzTobiasDLR reviewed Dec 15, 2023

View reviewed changes

franzTobiasDLR self-requested a review December 15, 2023 09:23

ngat_di and others added 2 commits December 15, 2023 13:45

Task #463 Fix the access rights management.

f96039e

Task #463 - Improve Code Quality

05f99e7

franzTobiasDLR approved these changes Dec 15, 2023

View reviewed changes

dellerDLR approved these changes Dec 15, 2023

View reviewed changes

dellerDLR merged commit 8027909 into development Dec 15, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/463 multiple users per discipline #1172

Feature/463 multiple users per discipline #1172

DimitriDiantos commented Sep 26, 2023 •

edited

Loading

DimitriDiantos commented Oct 10, 2023

franzTobiasDLR left a comment

franzTobiasDLR commented Nov 23, 2023

dellerDLR Nov 29, 2023

franzTobiasDLR Dec 4, 2023

dellerDLR Dec 5, 2023

dellerDLR Nov 29, 2023

DimitriDiantos Dec 6, 2023

dellerDLR commented Dec 6, 2023 •

edited

Loading

dellerDLR commented Dec 6, 2023

dellerDLR commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

dellerDLR commented Dec 8, 2023

dellerDLR commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

DimitriDiantos commented Dec 15, 2023

Feature/463 multiple users per discipline #1172

Feature/463 multiple users per discipline #1172

Conversation

DimitriDiantos commented Sep 26, 2023 • edited Loading

DimitriDiantos commented Oct 10, 2023

franzTobiasDLR left a comment

Choose a reason for hiding this comment

franzTobiasDLR commented Nov 23, 2023

dellerDLR Nov 29, 2023

Choose a reason for hiding this comment

franzTobiasDLR Dec 4, 2023

Choose a reason for hiding this comment

dellerDLR Dec 5, 2023

Choose a reason for hiding this comment

dellerDLR Nov 29, 2023

Choose a reason for hiding this comment

DimitriDiantos Dec 6, 2023

Choose a reason for hiding this comment

dellerDLR commented Dec 6, 2023 • edited Loading

dellerDLR commented Dec 6, 2023

dellerDLR commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

DimitriDiantos commented Dec 6, 2023

dellerDLR commented Dec 8, 2023

dellerDLR commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

dellerDLR commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

DimitriDiantos commented Dec 14, 2023

DimitriDiantos commented Dec 15, 2023

DimitriDiantos commented Sep 26, 2023 •

edited

Loading

dellerDLR commented Dec 6, 2023 •

edited

Loading