-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default class when original was not found #25
Add default class when original was not found #25
Conversation
the original class wasn't found.
Hi @bguban Thanks for the PR! May I request the following changes:
Thanks! |
I can easily change the class name but I need help with tests. Any suggestions on where would be a proper place to check it? Should I create a separate test for RedisDeserializationVisitor or add an expectation to an existing test? |
Good questions! I'm also wondering what the ramifications would be if retrying a task against the Unknown type will be, so will want to cover that in the tests too. I'll have a think to see what makes sense. Btw I gave your UI a try. Managed to get it running very easily as per the readme instructions. I guess this PR should get sorted so that it works properly if a module or job type is missing. |
move TestJob et al into supporting role add new supporting classes
NB: constrain sidekiq to versions < 7.x
Add default class when original was not found
Fixes #24