Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavBar customization #12

Closed
NuclearInstruments opened this issue Oct 8, 2021 · 8 comments
Closed

NavBar customization #12

NuclearInstruments opened this issue Oct 8, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@NuclearInstruments
Copy link

Hi,
I'm Andrea. First of all congratulations for the great work!

I would like to ask you if there is any way to hide the Light/Dark switch on the NavBar without modify your code.
Is there any way to open the NavBar in "mobile mode" (icons only) when the page is opened?

Thank You
Andrea

@virtualvivek
Copy link
Owner

virtualvivek commented Oct 8, 2021

Hi @NuclearInstruments ,

Thankyou soo much for your support!! :)

  1. Do you need some prop to show / hide the switch on navbar ??
  2. Do you need some prop to make navbar show top horizontal instead of Side Start in Desktop mode also??

@virtualvivek virtualvivek added the enhancement New feature or request label Oct 8, 2021
@virtualvivek
Copy link
Owner

Hi @NuclearInstruments ,

I will suggest you to check the new published version,
I have improved the navbar and now it only has some major component and other components can add externally.

@NuclearInstruments
Copy link
Author

Dear Vivek,
i tested the new version.
Two point:

  1. Version 4.0.4
    Adding AppTheme to App.js has no effect and the theme is always light
    <AppTheme
    scheme={'dark'}
    onColorChange={()=> {}}
    onSchemeChange={()=> {}}

       />
    
  2. If i try to upgrade the version to one greater than 4.0.4 I got

Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

Check the render method of App.
▶ 22 stack frames were collapsed.
Module.
C:/temp/react-windows-ui-boilerplate/src/index.js:8
5 | import 'react-windows-ui/icons/fonts/fonts.min.css'
6 | import App from './App'
7 |

8 | ReactDOM.render(
9 | <React.StrictMode>
10 |
11 | </React.StrictMode>,

to be sure i started from an empty project fro your last Boilerplate https://github.com/virtualvivek/react-windows-ui-boilerplate.git

Thank you
Andrea

@virtualvivek virtualvivek pinned this issue Nov 28, 2021
@virtualvivek
Copy link
Owner

Hi Andrea aka @NuclearInstruments ,

I have checked in my local machine and you are right AppTheme has no effect on "dark" prop on mount at App.js,

also apologies for -v4.0.5 actually for 4.0.5 i forget to import React from 'react' thats why after 10-15 mins of publishing i had to publish another -v4.0.6 but after i got your response, i am working on both boilerplate and repo, and give me some time to publish a more stable and rightfull version. :)

@virtualvivek
Copy link
Owner

Hi @NuclearInstruments ,

I have fixed this issue of AppTheme and also updated boilerplate.
This new release removed TransitionToLeft component because new version don't require this component so,
You can check the new release at your side and update me whether this issue needs to be closed.

@andreaabba
Copy link

Hi Vivek,
i tested the new release ad it works perfectly. The theme is applied and there is no more error on load.
Thank you very much
Andrea

@NuclearInstruments
Copy link
Author

Sorry I replied with my personal github account. I close now the issue.
Thank You
Andrea

@virtualvivek
Copy link
Owner

virtualvivek commented Dec 3, 2021

Hi @andreaabba aka @NuclearInstruments ,

I feel relaxed after listening about improvements in the new release version -v4.0.8
Now i am going to release at github this version too!

No Worries.... No matter from where you replied the thing matter is you replied :)
Thanks for contributing to this project also for the navigation part too!

@virtualvivek virtualvivek unpinned this issue Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants