-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use SyncLists directly (delete overrides) #2307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, you had to write an intermediary class to use synclists, syncsets and syncdictionaries. The weaver would populate that intermediary class with a serialization and deserialization method This PR gets rid of 90% of the weaver code for synclists. There is no need to generate these methods anymore. Instead the lists use `writer.Write<T>` and `read.read<T>` to serialize their Data. Since there is no code generate in synclists, you can now use the synclists directly instead of subclassing them. BEFORE: ```cs public class MyComponent : NetworkBehaviour { // nonsense class to make the weaver happy class SyncListData : Synclist<Data> {} SyncListData mySyncList; } ``` AFTER: ```cs public class MyComponent : NetworkBehaviour { Synclist<Data> mySyncList; } ```
Previously, you had to write an intermediary class to use synclists and syncdictionaries. The weaver would populate that intermediary class with a serialization and deserialization method This PR gets rid of 90% of the weaver code for synclists. There is no need to generate these methods anymore. Instead the lists use `writer.Write<T>` and `read.read<T>` to serialize their Data. Since there is no code generate in synclists, you can now use the synclists directly instead of subclassing them. Same as #2305 ,but it removes the deprecated Serialize and Deserialize methods from syncobjects, This way you get a nice compiler error for the code that no longer works, instead of a warning you might accidentally ignore. BEFORE: ```cs public class MyComponent : NetworkBehaviour { // nonsense class to make the weaver happy class SyncListData : Synclist<Data> {} SyncListData mySyncList; } ``` AFTER: ```cs public class MyComponent : NetworkBehaviour { Synclist<Data> mySyncList; } ``` BREAKING CHANGE: Serialize and Deserialize methods in synclists don't do anything anymore
SonarCloud Quality Gate failed. 0 Bugs |
miwarnec
pushed a commit
that referenced
this pull request
Oct 2, 2020
* feat: Use SyncLists directly Previously, you had to write an intermediary class to use synclists, syncsets and syncdictionaries. The weaver would populate that intermediary class with a serialization and deserialization method This PR gets rid of 90% of the weaver code for synclists. There is no need to generate these methods anymore. Instead the lists use `writer.Write<T>` and `read.read<T>` to serialize their Data. Since there is no code generate in synclists, you can now use the synclists directly instead of subclassing them. BEFORE: ```cs public class MyComponent : NetworkBehaviour { // nonsense class to make the weaver happy class SyncListData : Synclist<Data> {} SyncListData mySyncList; } ``` AFTER: ```cs public class MyComponent : NetworkBehaviour { Synclist<Data> mySyncList; } ``` * linting * feat: Use SyncLists directly (no overrides) Previously, you had to write an intermediary class to use synclists and syncdictionaries. The weaver would populate that intermediary class with a serialization and deserialization method This PR gets rid of 90% of the weaver code for synclists. There is no need to generate these methods anymore. Instead the lists use `writer.Write<T>` and `read.read<T>` to serialize their Data. Since there is no code generate in synclists, you can now use the synclists directly instead of subclassing them. Same as #2305 ,but it removes the deprecated Serialize and Deserialize methods from syncobjects, This way you get a nice compiler error for the code that no longer works, instead of a warning you might accidentally ignore. BEFORE: ```cs public class MyComponent : NetworkBehaviour { // nonsense class to make the weaver happy class SyncListData : Synclist<Data> {} SyncListData mySyncList; } ``` AFTER: ```cs public class MyComponent : NetworkBehaviour { Synclist<Data> mySyncList; } ``` BREAKING CHANGE: Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 2, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-02) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 3, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-03) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 4, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 4, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 4, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 4, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 4, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-04) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 5, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-05) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 5, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-05) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 6, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60)) * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) * nre modifying syncvars that have not been spawned ([69883c5](69883c5)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### Performance Improvements * Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed)) ### BREAKING CHANGES * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 6, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60)) * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) * nre modifying syncvars that have not been spawned ([69883c5](69883c5)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### Performance Improvements * Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed)) * Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd)) ### BREAKING CHANGES * It is no longer guaranteed that all objects are spawned before we start calling events * fix object spawning on scene change * remove unused variable Co-authored-by: uwee <uweenukr@gmail.com> * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 6, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60)) * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) * nre modifying syncvars that have not been spawned ([69883c5](69883c5)) ### Features * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### Performance Improvements * Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed)) * Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd)) ### BREAKING CHANGES * It is no longer guaranteed that all objects are spawned before we start calling events * fix object spawning on scene change * remove unused variable Co-authored-by: uwee <uweenukr@gmail.com> * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 6, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-06) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60)) * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) * nre modifying syncvars that have not been spawned ([69883c5](69883c5)) ### Features * Add IncludeOwner option to SendToAll ([#387](#387)) ([6b0a005](6b0a005)) * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### Performance Improvements * Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed)) * Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd)) ### BREAKING CHANGES * It is no longer guaranteed that all objects are spawned before we start calling events * fix object spawning on scene change * remove unused variable Co-authored-by: uwee <uweenukr@gmail.com> * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
github-actions bot
referenced
this pull request
in MirageNet/Mirage
Oct 7, 2020
# [47.0.0](v46.2.0...v47.0.0) (2020-10-07) ### breaking * Remove GameObject sync ([#370](#370)) ([5b223fa](5b223fa)) * Use SyncLists directly (delete overrides) ([#2307](https://github.com/MirrorNG/MirrorNG/issues/2307)) ([fb49d19](fb49d19)), closes [#2305](https://github.com/MirrorNG/MirrorNG/issues/2305) ### Bug Fixes * access NI on disabled objects ([#383](#383)) ([0ab4c60](0ab4c60)) * adding namespace for sonar bug ([2ed0859](2ed0859)) * bug Client ConnectionState not set properly in Disconnect ([#369](#369)) ([74298c5](74298c5)) * Bug with NI destroy order ([#374](#374)) ([485f78b](485f78b)) * Examples can exit property in client mode ([35faaf3](35faaf3)) * examples no longer use prefabs or common files ([#378](#378)) ([718ec9e](718ec9e)) * Lobby comp should not reference NetworkConnection.IsReady ([#385](#385)) ([6a1a190](6a1a190)) * networkmenu should add NSM to playerSpawner too ([c7bd0be](c7bd0be)) * nre modifying syncvars that have not been spawned ([69883c5](69883c5)) ### Features * Add IncludeOwner option to SendToAll ([#387](#387)) ([6b0a005](6b0a005)) * new generic Read and Write methods for all types ([#2301](https://github.com/MirrorNG/MirrorNG/issues/2301)) ([85252c3](85252c3)) * support Jagged arrays ([0267dbe](0267dbe)) ### Performance Improvements * Only synchronize dirty objects ([#381](#381)) ([64fd6ed](64fd6ed)) * Remove 2 messages when player connects ([#384](#384)) ([c40e0fd](c40e0fd)) ### BREAKING CHANGES * It is no longer guaranteed that all objects are spawned before we start calling events * fix object spawning on scene change * remove unused variable Co-authored-by: uwee <uweenukr@gmail.com> * You can no longer use gameobjects in syncvars * Serialize and Deserialize methods in synclists don't do anything anymore * Remove old comment * Fix compilatio error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you had to write an intermediary class to use synclists and syncdictionaries.
The weaver would populate that intermediary class with a serialization and deserialization method
This PR gets rid of 90% of the weaver code for synclists.
There is no need to generate these methods anymore.
Instead the lists use
writer.Write<T>
andread.read<T>
to serialize their Data.Since there is no code generate in synclists, you can now use the synclists directly instead
of subclassing them.
Same as #2305, but it removes the deprecated Serialize and Deserialize methods, in synclists.
This way you get a nice compiler error for code that won't work, instead of a warning you may accidentally ignore.
BEFORE:
AFTER:
BREAKING CHANGE: Serialize and Deserialize methods in synclists don't do anything anymore