-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MUI to V5 and fix a bunch of bad code #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't dig too deep into the code changes, but the ones I looked at seemed to not be a problem. I have one note about yarn, but it shouldn't hold up merging
frontend/package.json
Outdated
"typescript": "^4.3.4", | ||
"use-deep-compare-effect": "^1.6.1" | ||
"use-deep-compare-effect": "^1.6.1", | ||
"yarn": "^1.22.19" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's strange to have yarn
here. We should probably just switch over to yarn fully, and remove package-lock.json, if that's what you'd like to use to manage the packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you help me on making sure to clean up these? thank you very much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 3186ff7
Does this PR close any open issues?
Closes #225
Give a longer description of what this PR addresses and why it's needed
Provide pictures/videos of the behavior before and after these changes (optional)
Should all look the same with some minor aesthetic change
TODO