Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MUI to V5 and fix a bunch of bad code #227

Merged
merged 18 commits into from
Aug 16, 2022
Merged

Upgrade MUI to V5 and fix a bunch of bad code #227

merged 18 commits into from
Aug 16, 2022

Conversation

haihan-lin
Copy link
Collaborator

@haihan-lin haihan-lin commented Aug 4, 2022

Does this PR close any open issues?

Closes #225

Give a longer description of what this PR addresses and why it's needed

  • Upgrade MUI (some of the "lab" features have been added to the official library).
  • changed package manager from NPM to YARN
  • New styling engine Emotion instead of Styled-Components
  • Move dialog state management out of global state, into parts that actually trigger the dialog.

Provide pictures/videos of the behavior before and after these changes (optional)

Should all look the same with some minor aesthetic change

TODO

  • another thorough testing making sure no broken features

Copy link
Member

@JackWilb JackWilb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't dig too deep into the code changes, but the ones I looked at seemed to not be a problem. I have one note about yarn, but it shouldn't hold up merging

"typescript": "^4.3.4",
"use-deep-compare-effect": "^1.6.1"
"use-deep-compare-effect": "^1.6.1",
"yarn": "^1.22.19"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange to have yarn here. We should probably just switch over to yarn fully, and remove package-lock.json, if that's what you'd like to use to manage the packages

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you help me on making sure to clean up these? thank you very much

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 3186ff7

@haihan-lin haihan-lin merged commit d779438 into main Aug 16, 2022
@haihan-lin haihan-lin deleted the mui branch August 16, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade MUI to V5
2 participants