Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #85 #88

Merged
merged 3 commits into from
Jun 11, 2020
Merged

resolves #85 #88

merged 3 commits into from
Jun 11, 2020

Conversation

haihan-lin
Copy link
Collaborator

No description provided.

Haihan Lin added 3 commits June 11, 2020 14:35
@haihan-lin haihan-lin linked an issue Jun 11, 2020 that may be closed by this pull request
@haihan-lin haihan-lin merged commit e54cd96 into master Jun 11, 2020
@haihan-lin haihan-lin deleted the preview-mode branch June 11, 2020 21:57
@JackWilb
Copy link
Member

This is going to add more overhead for you supporting things as we continue to add more features. I think that doing it the way Alex proposed (with using conditional logic on the dashboard page) will be better and more maintainable long term

@haihan-lin
Copy link
Collaborator Author

It is using conditional logic. I just separate things out so that if we want more different stuff on the preview, it is easier to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to share as a report
2 participants