Skip to content

Commit

Permalink
fix: pinned jupyterlab to 4.0.4 because of
Browse files Browse the repository at this point in the history
upstream bug. aggressive key traps wont let text boxes work
  • Loading branch information
kirangadhave committed Nov 11, 2023
1 parent cafc590 commit 80c40d0
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 23 deletions.
39 changes: 21 additions & 18 deletions examples/test_ext_widget.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -189,42 +189,45 @@
"execution_count": 4,
"id": "3e1630c0-2ed8-4eb1-8045-c57d1fcdeb56",
"metadata": {
"__has_persist_output": true
},
"outputs": [],
"source": [
"# a = PR.PersistChart(chart, data=source)\n",
"# a = PR.PersistTable(data=source) "
]
},
{
"cell_type": "code",
"execution_count": 13,
"id": "598f7529-bd58-4cf5-9cda-307fbb4752d3",
"metadata": {
"__GENERATED_DATAFRAMES__": "ᯢ粠 ",
"__GENERATED_DATAFRAMES__": "ᯡࠣ䅬Ԁ朤壠ᜣ琢〹夥゠⹰〮⁁䁻қ䚾ኊ㇠നСࠩ瀮晼Ƭ穅5愠៤⠠ ",
"__has_persist_output": true,
"trrack_graph": "ᯡ࠽䈌ʀ匦㢠⹰ಀ㌠晳㬤〶䀫.ੑెŒ簤ᬂ圜ᠪ惭℠ᠧブ墠乮ⓀŌ傰䏂懦䁤䲥㕚٭ⷹ㬗爲&䈠۶䀱䘡撠┨ࠠ⺚₀ǘ憣屢֖绪+⢣⠠Ꭻ䤠ව׷根ᳬ䢼紴ろۦԠ޳ł烈Ȣ⩞×ၠӨ⟰˸悍㑂ၺᡄ᫆橁Ӭ⁧疭嘠殒浀㯌Ḱؗ気ᩑ㑈ᬤ㮄␮ӳ׉堢㰠໫睿పᯝㄪᖗ婚槭䡀煩✴挲㧥ڄ惑঑䖼粃ㅁിڦ䋁⃦ᔶ䀰惹ਾ捺㚲≦٫ᛣቔㄢ˶᮪ⓣ゘ᄴ䝂ࢴാ䒃ᢌܧ䐂Ӣɠ֢֔揖断䨄㱲䑭⥩ഥ᷆দ† "
"trrack_graph": "ᯡ࠽䈌ʀ匦㢠⹰ˠ⌡䙈ᖭϐĀୠᎤ娡᢯║ϐࢀ೨䔡堫㊖♑䛣&ተ¶⡨⇱㌄ᕎ╦仃஖份㸙Ҡǁ#む҃࿒′䈤7⺰ᠠ湐憎Ⴄ姗ㆠ˴㽴3姩-倥樋甽♨䅝ذ↺挥'䦡ჰ屄㙖㸾༼䊧倥壣ⰸ≀ِ␥㫴℡䱧؉ೌöኦg㑌ါ珱瑕ᠸ᣶ж䑨฾匥⻐ʘ<எἸا▂ੂ珐㡑䶰ℂ䤸ਠᦲ綧䂂ᇀᡨ埴⯜଩̨桄⃦惠дਥ㧼ᡋ䂧㍌歩Ńńଡ䤴ᢠŋᗥኀ㢜ᢦ≱呔ᚤ⏱䱶Υ愐簡ᡯࠡ⸡ၠ玓⓸岯౲৪⥍⃆㓴䠠㈠ "
},
"outputs": [
{
"data": {
"application/vnd.jupyter.widget-view+json": {
"model_id": "a400d56dc89c4d98aca9e1b680cd25bc",
"model_id": "5a3d31a67a9d4e48aa632fe45bfa8992",
"version_major": 2,
"version_minor": 0
},
"text/plain": [
"PersistWidget(data_values=[{'__id_column': '1', 'Name': 'chevrolet chevelle malibu', 'Miles_per_Gallon': 18.0,…"
]
},
"execution_count": 13,
"execution_count": 4,
"metadata": {},
"output_type": "execute_result"
}
],
"source": [
"PR.plot.barchart(source, x=\"utcyear(Year):O\", y=\"count():Q\")"
"# a = PR.PersistChart(chart, data=source)\n",
"a = PR.PersistTable(data=source)\n",
"a"
]
},
{
"cell_type": "code",
"execution_count": 5,
"id": "598f7529-bd58-4cf5-9cda-307fbb4752d3",
"metadata": {
"__GENERATED_DATAFRAMES__": "ᯡࠣ䅬Ԁ朤壠ᜣ琢〹夦゠⹰〮⁁䁻қ䚾ኊ㇠നСࠩ瀮晼Ƭ穅5愠៤⠠ ",
"__has_persist_output": true,
"trrack_graph": "ᯡ࠽䈌ʀ匦㢠⹰ಀ㌠晳㬤〶䀫.ੑెŒ簤ᬂ圜ᠪ惭℠ᠧブ墠乮ⓀŌ傰䏂懦䁤䲥㕚٭ⷹ㬗爲&䈠۶䀱䘡撠┨ࠠ⺚₀ǘ憣屢֖绪+⢣⠠Ꭻ䤠ව׷根ᳬ䢼紴ろۦԠ޳ł烈Ȣ⩞×ၠӨ⟰˸悍㑂ၺᡄ᫆橁Ӭ⁧疭嘠殒浀㯌Ḱؗ気ᩑ㑈ᬤ㮄␮ӳ׉堢㰠໫睿పᯝㄪᖗ婚槭䡀煩✴挲㧥ڄ惑঑䖼粃ㅁിڦ䋁⃦ᔶ䀰惹ਾ捺㚲≦٫ᛣቔㄢ˶᮪ⓣ゘ᄴ䝂ࢴാ䒃ᢌܧ䐂Ӣɠ֢֔揖断䨄㱲䑭⥩ഥ᷆দ† "
},
"outputs": [],
"source": [
"# PR.plot.barchart(source, x=\"utcyear(Year):O\", y=\"count():Q\")"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "persist_ext",
"version": "1.5.8",
"version": "1.5.9-rc0",
"description": "PersIst is a JupyterLab extension to enable persistent interactive visualizations in JupyterLab notebooks.",
"keywords": [
"jupyter",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ classifiers = [
]
dependencies = [
"altair>=5",
"jupyterlab>=4",
"jupyterlab==4.0.4",
"pandas>=0.25",
"ipywidgets",
"anywidget",
Expand Down
2 changes: 1 addition & 1 deletion src/widgets/header/categoryHelpers.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useEffect, useMemo, useRef, useState } from 'react';
import { useEffect, useMemo, useRef } from 'react';
import { useListState, useSessionStorage } from '@mantine/hooks';
import { Categories, Option } from '../../interactions/categorize';

Expand Down
3 changes: 3 additions & 0 deletions src/widgets/interactive_table/ColumnHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ export function ColumnHeader({ column, allColumns, cell }: Props) {
setIsEditing(false);
}}
autoFocus
onClick={e => {
e.stopPropagation();
}}
onKeyDown={getHotkeyHandler([['Enter', () => ref.current?.blur()]])}
size="xs"
/>
Expand Down
3 changes: 1 addition & 2 deletions src/widgets/interactive_table/helpers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ export function useColumnDefs(
row.getValue(column.id),
dTypeMap[column.id],
true
),
defaultValue: new Date() as any
)
};
}
}));
Expand Down

0 comments on commit 80c40d0

Please sign in to comment.