-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute consolidation #352
Conversation
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dff5746
to
bf76a1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are related to documentation. I think that, at a minimum, all types and functions need to be documented. In particular, the Props
types used to pass arguments to components are important to document as those serve as the only documentation for the component's parameters. I know that's a deviation from the historical norm in this repo but I think we should aim to add documentation as we update the code even if that creates a mismatch in documentation amounts throughout the code.
Also, what's your tab width set to in VSCode? There are a couple spots where it looks like it defaulted to 4 spaces, but most of the repo appears to use 2 spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two conversations remain unresolved, but neither is worth delaying the PR. Everything else looks good & I especially appreciate all of the added documentation that wasn't specifically requested.
Does this PR close any open issues?
Closes #297 #308 #22 #123
Give a longer description of what this PR addresses and why it's needed
This PR consolidates both Deviation and Degree into the attribute list so that the columns can be removed, and eventually universally sorted by. This improves the dynamic UI (see #1 ) and makes the sorting refactor (#123 ) for attributes simpler in the future, as hard coded sort values are now included in the attribute list.
Note: Deviation will always appear as the first item in the attributes list, as it isn't really an attribute, but is handled in a similar way by the dropdown menu.
Bundled in with this is a mini-refactor of attribute header and bar rendering to improve readability and scalability.
Provide pictures/videos of the behavior before and after these changes (optional)
BEFORE:
AFTER:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: