Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update selected size bar color to match bookmark color #357

Merged
merged 1 commit into from
May 2, 2024

Conversation

NateLanza
Copy link
Contributor

Does this PR close any open issues?

Closes #343

Give a longer description of what this PR addresses and why it's needed

Previously, when selecting a non-bookmarked intersection, the size bar would be a fixed light blue color while the chip in Element View would show the intersection using the next bookmark color. Now, the size bar of the selected intersection also uses the next bookmark color.

Provide pictures/videos of the behavior before and after these changes (optional)

Before:
343-before
After:
343-after

Have you added or updated relevant tests?

  • Yes
  • No changes are needed (I can try and write a test to check the color of the element if you'd like)

Have you added or updated relevant documentation?

  • Yes
  • No changes are needed

Are there any additional TODOs before this PR is ready to go?

TODOs:

  • ...

@NateLanza NateLanza requested a review from JakeWags April 30, 2024 04:05
@NateLanza NateLanza self-assigned this Apr 30, 2024
@NateLanza NateLanza linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for upset2 ready!

Name Link
🔨 Latest commit 39a7b3a
🔍 Latest deploy log https://app.netlify.com/sites/upset2/deploys/66306e205910b20008ae256c
😎 Deploy Preview https://deploy-preview-357--upset2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JakeWags JakeWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Approved

@NateLanza NateLanza merged commit f288640 into main May 2, 2024
7 checks passed
@NateLanza NateLanza deleted the 343-selection-color branch May 2, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync selection color with bookmark color
2 participants