Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add nebula.gl modules #37

Merged
merged 9 commits into from Apr 3, 2024
Merged

chore: Add nebula.gl modules #37

merged 9 commits into from Apr 3, 2024

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Mar 28, 2024

This PR forks nebula.gl into this repo withe the following module mapping:

nebula module (path) Description Forked module
nebula.gl (modules/main) The core module => deck.gl-editable-layers
@nebula.gl/edit-modes (modules/edit-modes) Optional edit modes => deck.gl-editable-layers
@nebula.gl/layers (modules/layers) The actual layers => deck.gl-editable-layers
@nebula.gl/editor (modules/editor) React wrapper => react-deck.gl-editable-layers
@nebula.gl/overlays (modules/overlays) React General overlays => react-deck.gl-editable-layers
react-map-gl-draw (modules/react-map-gl-draw) Non-deck-wrapper => NOT FORKED

@chrisgervang
Copy link

This module grouping makes sense to me. I can imagine most of the features in react-deck.gl-editable-layers being implemented as a deck.gl widget, which would work for both react and pure-js applications.

@ibgreen
Copy link
Contributor Author

ibgreen commented Apr 2, 2024

Yes I think the goal should be to sunset / remove the react module if at all possible. Whatever it offers should be available to all bindings.

  • We should create a list of reasons why it is needed and brainstorm about ways we can solve those needs in react-independent ways.

@felixpalmer felixpalmer mentioned this pull request Apr 3, 2024
35 tasks
@ibgreen ibgreen merged commit 9be4ebc into master Apr 3, 2024
1 check passed
@ibgreen ibgreen deleted the ib/nebula branch April 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants