Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't add and remove layer #14

Closed
heshan0131 opened this issue Feb 4, 2016 · 8 comments
Closed

can't add and remove layer #14

heshan0131 opened this issue Feb 4, 2016 · 8 comments
Labels

Comments

@heshan0131
Copy link
Collaborator

run into error:
[object] has other than one matching layers

@ibgreen
Copy link
Collaborator

ibgreen commented Feb 9, 2016

@wwwtyro this is becoming a critical issue for Shan's app.

The issue is related to the layer needing to register a new Program etc, it always seemed hard to fix in PhiloGL since it uses a declarative approach for setting up programs making it a little tricky to figure out how to add and remove them after initialization.

This should be much more straightforward to fix using luma.gl once the ongoing port is complete.

@heshan0131 We might want to extend the example code to add and removes layers in a way that reproduces the issue.

@wwwtyro
Copy link
Contributor

wwwtyro commented Feb 9, 2016

👍 It'd be great if I can get a reproducible example.

@heshan0131
Copy link
Collaborator Author

@wwwtyro I will edit the example code, and do a pull request?

@wwwtyro
Copy link
Contributor

wwwtyro commented Feb 9, 2016

That'll work, or you can just make a branch and push it and tell me where it's at so I can try it. :)

@heshan0131
Copy link
Collaborator Author

yes will do

@heshan0131
Copy link
Collaborator Author

@wwwtyro
Copy link
Contributor

wwwtyro commented Feb 9, 2016

Thanks! I'll make sure it works when I get luma.gl working with deck.gl. :)

@ibgreen
Copy link
Collaborator

ibgreen commented Feb 28, 2016

@heshan0131 Please retest this on the performance branch. Layer handling has been rewritten so if it is still an issue let us fix it in the right place.

@ibgreen ibgreen closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants