New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't add and remove layer #14
Comments
@wwwtyro this is becoming a critical issue for Shan's app. The issue is related to the layer needing to register a new Program etc, it always seemed hard to fix in PhiloGL since it uses a declarative approach for setting up programs making it a little tricky to figure out how to add and remove them after initialization. This should be much more straightforward to fix using luma.gl once the ongoing port is complete. @heshan0131 We might want to extend the example code to add and removes layers in a way that reproduces the issue. |
👍 It'd be great if I can get a reproducible example. |
@wwwtyro I will edit the example code, and do a pull request? |
That'll work, or you can just make a branch and push it and tell me where it's at so I can try it. :) |
yes will do |
@wwwtyro |
Thanks! I'll make sure it works when I get luma.gl working with deck.gl. :) |
@heshan0131 Please retest this on the performance branch. Layer handling has been rewritten so if it is still an issue let us fix it in the right place. |
run into error:
[object] has other than one matching layers
The text was updated successfully, but these errors were encountered: