-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps fail to render in Safari 15.1 #6414
Comments
Some observations:
I will look closer but if you could pinpoint what usage pattern caused the error it will be easier for us to identify a work around, and/or report the bug to WebKit. |
It's a bit tricky, because I discovered this issue using the R package {mapdeck}, which is an R interface to Mapbox and deck.gl. I have no experience using deck.gl directly. But it appears that the entirety of mapdeck's deck.gl rendering fails to work in Safari 15.1. I have a bunch of projects using mapdeck with all sorts of polygons, points, lines, etc, and they all fail to render. This is the most minimal R code which produces the error—simply trying to draw basic polygons. library(sf)
library(mapdeck)
nc <- st_read(system.file("shape/nc.shp", package="sf"))
add_polygon(mapdeck(), nc) |
Do you have an example of points that fail to render? |
Here is a test project with points which renders fine on Chrome or Safari 15.4, but not 15.1: https://mssi.shinyapps.io/lines_test/ I also tested lines (hence the project name), and they also fail to render. |
I'm having this issue as well with Safari 15.1 I see it has been reported on the Apple Developer Forums as well: https://developer.apple.com/forums/thread/688561 |
@dwachsmuth Please share the source of your points/lines test app. We cannot debug minified script. @titivermeesch At this point, it is unclear what usage triggers the failure, as most apps seem to work fine on 15.1. If you can share your code that triggers this issue, it would help us identify a fix. |
Update: The fiddle in the original issue: https://jsfiddle.net/symbolixau/on7432fj/70/ is supplying too small of a buffer to Using insufficient buffers for attributes results in a The "program not valid" error is due to the fiddle using an outdated version of deck.gl. There was a fix for Safari 15 in v8.5, see visgl/luma.gl#1490 |
After updating to the latest version the issue fixed itself |
Looks like this is an issue resolvable by upgrading mapdeck to the latest release. @dcooley Example in the original post has other issues unrelated to the library's compatibility. Reopen if the problem remains. |
Unfortunately my issue is still present in the current version of mapdeck. This is the minimal reprex in R to produce the issue:
Opening the localhost session works fine in Chrome or in Safari 15.4, but not in Safari 15.1. |
(I also don't seem to be able to re-open the issue, but it is definitely still live on my end!) |
@dwachsmuth Please work with the author of mapdeck to upgrade its deck.gl dependency. |
Description
Basic deck.gl maps fail to render in the current version of Safari (15.1, on macOS Monterey 12.0.1).
Expected Behavior
Visiting a simple deck.gl sample project should show rainbow polygons drawn with deck.gl over the basemap: https://jsfiddle.net/symbolixau/on7432fj/70/
On Chrome 95, the polygons display:
![Screen Shot 2021-11-17 at 19 47 09](https://user-images.githubusercontent.com/41338507/142326109-cfabe2e9-e82e-4687-a653-7f5b4aa754ad.png)
On Safari 15, the polygons do not display:
![Screen Shot 2021-11-17 at 19 50 19](https://user-images.githubusercontent.com/41338507/142326605-e24067f9-87f6-4ab4-84f8-b6e57f35e83e.png)
Repro Steps
Visit https://jsfiddle.net/symbolixau/on7432fj/70/ on Safari 15 on macOS—the polygons should render, but they don't.
Environment
Logs
There are several errors in the console log. The one that seems potentially related is:
This issue is a redirect from SymbolixAU/mapdeck#347 where I initially encountered it. The package maintainer of {mapdeck} thinks there is a compatibility issue between deck.gl and Safari.
The text was updated successfully, but these errors were encountered: