Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OrbitView example broken in v9 #8266

Closed
7 tasks
felixpalmer opened this issue Nov 8, 2023 · 3 comments · Fixed by #8289
Closed
7 tasks

[Bug] OrbitView example broken in v9 #8266

felixpalmer opened this issue Nov 8, 2023 · 3 comments · Fixed by #8289
Assignees
Labels

Comments

@felixpalmer
Copy link
Collaborator

Description

The OrbitView example is broken in v9.

This issue is not so much down to a problem with OrbitView itself, but that the example uses 3 custom layers which have yet to be ported to the v9 API. These layers will need to be converted to Typescript and fixed following the approach used in (e.g.) the core layers

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

No response

Steps to Reproduce

https://felixpalmer.github.io/deck.gl/examples/plot or run examples/website/plot on master branch

Environment

  • Framework version: 9
  • Browser:
  • OS:

Logs

No response

@felixpalmer felixpalmer added the bug label Nov 8, 2023
@donmccurdy donmccurdy self-assigned this Nov 14, 2023
@donmccurdy
Copy link
Collaborator

@felixpalmer - Do you (or others) have a preference about converting the entire example to TypeScript, or just the -layer.js files, or something else? I do find the type-checking helpful, just want to make sure the example is still approachable.

Enabling "allowJs": true mode in tsconfig.json might be an alternative if we want the examples to use plain JavaScript, but to still have compile-time errors about incorrect usage.

@felixpalmer
Copy link
Collaborator Author

I think it makes sense to convert the layer files, as they are complex and would benefit from the type checking. Just switching to Typescript should help the migration to v9 as many errors will be flagged

@donmccurdy
Copy link
Collaborator

Sounds good to me -- opened #8289.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants