You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue is not so much down to a problem with OrbitView itself, but that the example uses 3 custom layers which have yet to be ported to the v9 API. These layers will need to be converted to Typescript and fixed following the approach used in (e.g.) the core layers
@felixpalmer - Do you (or others) have a preference about converting the entire example to TypeScript, or just the -layer.js files, or something else? I do find the type-checking helpful, just want to make sure the example is still approachable.
Enabling "allowJs": true mode in tsconfig.json might be an alternative if we want the examples to use plain JavaScript, but to still have compile-time errors about incorrect usage.
I think it makes sense to convert the layer files, as they are complex and would benefit from the type checking. Just switching to Typescript should help the migration to v9 as many errors will be flagged
Description
The OrbitView example is broken in v9.
This issue is not so much down to a problem with
OrbitView
itself, but that the example uses 3 custom layers which have yet to be ported to the v9 API. These layers will need to be converted to Typescript and fixed following the approach used in (e.g.) the core layersFlavors
Expected Behavior
No response
Steps to Reproduce
https://felixpalmer.github.io/deck.gl/examples/plot or run
examples/website/plot
onmaster
branchEnvironment
Logs
No response
The text was updated successfully, but these errors were encountered: