[Bug] Column Layer not rendering on Samsung's latest devices with Chrome 120 (eg: S23, S22, Fold) #8411
Closed
1 of 7 tasks
Labels
Comments
|
Same 💯 |
|
May have to do with the use of directives in the fragment shader. We don't have a Samsung device for testing. Any suggestions how we can test a fix? |
|
Hi @Pessimistress , thanks for the response, we can test the changes if you have accessible staging/testing environment URLs. or if you have browserstack sub, we can make use of that as well. |
|
@gyanender-singh-phonepe Appreciate your help! Can you try set the |
|
@Pessimistress We tried adding the flatShading prop. It didn't work. new HexagonLayer({
data,
colorRange: [],
coverage: 0.9,
opacity: 0.4,
useDevicePixels: false,
radius: 7500,
elevationRange: [0, 100],
elevationScale: 3500,
extruded: true,
pickable: false,
material: {
ambient: 0.64,
diffuse: 0.6,
shininess: 320,
specularColor: [51, 51, 51],
},
transitions: {
getElevationValue: 1000,
},
flatShading: true,
_subLayerProps: {
"hexagon-cell": { flatShading: true },
"HexagonLayer-hexagon-cell": { flatShading: true },
},
})Getting the same error: 
|
|
I tried to trace it commit by commit. It's breaking since this commit @Pessimistress , 3679a92 |
|
Your issue is about the v8 release. That commit is not in production. |
|
Not sure, I was checking the local setup of deck.gl as mentioned in - CONTRIBUTING.md This layer breaks like this - If not related to our use case, this might be some other issue. Let me try to narrow it down more. |
|
You should use the 8.9-release branch then. Master branch's render pipeline is rewritten completely. |
|
okay |
|
breaking since both 8.7.0-beta.7 and 8.7.0 |
|
@gyanender-singh-phonepe can you test ColumnLayer directly? |
|
been trying to compile the 8.7-release for past 2 hours, but with no luck Details
|
|
@Pessimistress with Deck.gl version 8.6.8 it is working fine. |
|
v8.7.0 is when |
|
We are facing the same issue in v8.9.34, I have tested on a Xiaomi MI 9T / Chrome for Android v124. Hexagon layer works correctly in desktop but fails to build the shader in mobile. The example in the docs (https://deck.gl/docs/api-reference/aggregation-layers/hexagon-layer) does not work. I have attached some snapshots showcasing how it looks in mobile and desktop, the error in the mobile console, plus a code snapshot reproducing the failure. 
|
Updating on the previous message, after updating to Deck 9.0.10 the issue persists |
|
@ankurparihar @cegonse Can you test https://codepen.io/Pessimistress/pen/RwOdxgP on your device? |
|
@Pessimistress It seems to be working fine, great job. What was the fix for the layer? Edit: nevermind just saw the associated pull request , thank you! |
|
This is working on my device. Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I am encountering a rendering issue with the Column Layer in deck.gl specifically on Samsung S23 and Fold devices. Upon opening a page containing the Column Layer, the browser becomes unresponsive, and the layer fails to render properly. Additionally, the example provided in deck.gl's documentation (deck.gl/docs/api-reference/layers/column-layer) also exhibits the same problem.
Actual Behavior
The browser becomes unresponsive, and the Column Layer fails to render as expected. I observed GLSL compilation errors in the fragment shader column-layer-fragment-shader-1.
Screenshots
Breaking on S23 chrome:
Working on S23 Samsung browser:
Flavors
Expected Behavior
The Column Layer should render correctly without causing the browser to freeze on Samsung S23 or Fold devices.
Steps to Reproduce
Visit https://deck.gl/docs/api-reference/layers/column-layer on Samsung's S23, S22 or Fold.
Environment
Chrome Version:
Logs
The text was updated successfully, but these errors were encountered: