Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core) publish NPM packages from CI #274

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented May 22, 2024

Background

Aligned with visgl/deck.gl#8828

After this PR, the publish workflow will be

  • Switch to the appropriate branch (master for alpha/beta in development or *-release for production)
  • Edit CHANGELOG.md
  • Run yarn publish-beta or yarn publish-prod (note: with dash)

The publish command will only bump versions in package.json files, tag the commit and push to remote. The CI will then test, build, and publish to NPM.

As discussed offline, this will remove the differences in local dev environments and ensure predictable results. Also saves us time from working around render test inconsistencies and random errors.

I have tested the version bumping and tagging part of the workflow. Can't verify the CI workflow until merged. May need to follow up with more PRs to fix any CI issues.

Change List

  • Bump ocular-dev-tools
  • Enforce changelog update before publishing
  • Release CI flow

Change List (outside this PR)

  • Add npm access token as secret
  • Restrict push permission of *-release branches to admins only

Signed-off-by: Chris Gervang <chris@gervang.com>
@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9195943884

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.533%

Totals Coverage Status
Change from base Build 9183175190: 0.0%
Covered Lines: 1557
Relevant Lines: 2851

💛 - Coveralls

chrisgervang and others added 5 commits May 21, 2024 18:39
Signed-off-by: Chris Gervang <chris@gervang.com>
Signed-off-by: Chris Gervang <chris@gervang.com>
@chrisgervang chrisgervang merged commit 80ebf5b into master May 22, 2024
1 check passed
@chrisgervang chrisgervang deleted the chr/publish-from-ci branch May 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants