perf: prevent iterating through typed array if using SharedArrayBuffer (

#859)
visgl · Jul 17, 2020 · e43b493 · e43b493
1 parent e9228a2
commit e43b493
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/modules/loader-utils/src/lib/worker-utils/get-transfer-list.js b/modules/loader-utils/src/lib/worker-utils/get-transfer-list.js
@@ -16,6 +16,9 @@ export function getTransferList(object, recursive = true, transfers) {
   } else if (isTransferable(object.buffer)) {
     // Typed array
     transfersSet.add(object.buffer);
+  } else if (ArrayBuffer.isView(object)) {
+    // object is a TypeArray viewing into a SharedArrayBuffer (not transferable)
+    // Do not iterate through the content in this case
   } else if (recursive && typeof object === 'object') {
     for (const key in object) {
       // Avoid perf hit - only go one level deep