Tracker: v3.0 Release checklist

[ibgreen]

• Lighting is broken in gltf example?
• MVTLoader tests fail under Safari (yarn test browser, open localhost:5000 in Safari) P1 @kylebarron @jesusbotella
• deck.gl
  • Update 3d-tile example to not import and register DracoLoader @dryabinin-actionengine
  • Update gltf example to not import and register DracoLoader @dryabinin-actionengine
  • Update 3d-tile JSON example to not import and register DracoLoader @dryabinin-actionengine
  • Update i3s JSON example to not import and register DracoLoader @dryabinin-actionengine
  • Update pydeck examples to not import and register DracoLoader @dryabinin-actionengine
  • Remove draco install from package.json files @dryabinin-actionengine

[kylebarron]

• MVTLoader tests fail under Safari

It's this test that's failing.

loaders.gl/modules/mvt/test/mvt-loader.spec.js

Lines 125 to 144 in 112b16c

	test('Polygons MVT to GeoJSON', async t => {
	const response = await fetchFile(MVT_POLYGONS_DATA_URL);
	const mvtArrayBuffer = await response.arrayBuffer();
	const loaderOptions = {
	mvt: {
	coordinates: 'wgs84',
	tileIndex: {
	x: 133,
	y: 325,
	z: 10
	}
	}
	};
	const geojson = await parse(mvtArrayBuffer, MVTLoader, loaderOptions);
	t.deepEqual(geojson, decodedPolygonsGeoJSON);
	t.end();
	});

Specifically it looks like there are some float precision errors in Safari. The created geojson is expected to match this file. In this screenshot the first console.log is the geojson decoded from MVT, and the latter is what's expected to match. There are several such differences.

So I'd guess a good solution would be to use some epsilon instead of strict equality for float checking here?

[ibgreen]

Thanks for investigating, this makes sense. It is not really a bug then, but nevertheless, it would be good to get a clean test run.

There is a test/utils/tape-assertions that exports tapeEqualsEpsilon(t, value, expected, epsilon, message),