-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker: v3.0 Release checklist #772
Comments
It's this test that's failing. loaders.gl/modules/mvt/test/mvt-loader.spec.js Lines 125 to 144 in 112b16c
Specifically it looks like there are some float precision errors in Safari. The created geojson is expected to match this file. In this screenshot the first So I'd guess a good solution would be to use some epsilon instead of strict equality for float checking here? |
Thanks for investigating, this makes sense. It is not really a bug then, but nevertheless, it would be good to get a clean test run. There is a |
yarn test browser, open localhost:5000 in Safari
) P1 @kylebarron @jesusbotellaThe text was updated successfully, but these errors were encountered: