feat(textures): Add texture format utils #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dryabinin94
approved these changes
Jan 26, 2021
|
Test is failed |
ibgreen
commented
Jan 26, 2021
| /* global document */ | ||
| const canvas = document.createElement('canvas'); | ||
| return canvas.getContext('webgl'); | ||
| } catch { |
There was a problem hiding this comment.
This requires updating JS settings to latest JS syntax, to fix easily do:
Suggested change
| } catch { | |
| } catch (error) { |
dryabinin94
force-pushed
the
ib/texture-format-utils
branch
from
920b0e4
to
73816a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSupportedGPUTextureFormats()to discover which formats are available.getSupportedGPUTextureFormats()intexturesexamplegetSupportedGPUTextureFormats()inbasisdecoder, align constants and code@dryabinin-actionengine Please take over and land