-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(geotiff): RGB GeoTIFFLoader #2839
feat(geotiff): RGB GeoTIFFLoader #2839
Conversation
@giovannicimolin I sent you an invite to the loaders.gl repository. That way you can push branches directly instead of working through a fork. It would be nice if you could reopen this PR against a local branch, then I can push commits to your branch more easily. This can be quicker than writing a lot of feedback and waiting for you to make every small change. |
interface GeoTiffLoaderOptions extends LoaderOptions { | ||
enableAlpha: boolean; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Follow pattern set by other loaders
interface GeoTiffLoaderOptions extends LoaderOptions { | |
enableAlpha: boolean; | |
} | |
export type GeoTiffLoaderOptions = LoaderOptions & { | |
geotiff?: { | |
enableAlpha: boolean; | |
} | |
} |
@@ -0,0 +1,68 @@ | |||
import { fromArrayBuffer } from "geotiff"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: following pattern in other loader modules I would name this file geotiff-loader.ts
@ibgreen That was fast! I didn't even had the time to fix the comments you made. 😅 I'll create a follow-up PR with fixing the comments and adding some items from the todo list too. Thanks for the quick review! |
Didn't want this to go stale. I already put up a PR with fixes |
This is an experimental version of a GeoTIFF loader. Its goal is to add native RGB GeoTIFF rendering support for deck.gl to render aerial images, orthophotos and overlays into a deck instance.
Discussion on: #1280
TODO:
Testing instructions:
TBD