core: loader option util improvements #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Jun 30, 2020
| | `options.metadata` | boolean | `false` | Currently only implemented for `parseInBatches`, adds initial metadata batch | | ||
| | `options.log` | object | `console` | By default set to a `console` wrapper. Setting log to `null` will turn off logging. | | ||
| | `options.worker` | boolean | `true` | If the selected loader is equipped with a worker url (and the runtime environment supports it) parse on a worker thread. | | ||
| | `options.CDN` | string | - | Load workers and scripts from this source, defaults to `'https://unpkg.com/@loaders.gl'` | |
There was a problem hiding this comment.
Will there still be a workerUrl parameter for each loader as well? In some, e.g. Terrain, there's a loader option for the worker url
There was a problem hiding this comment.
Yes.. nothing has changed in the implementation. Just surfacing existing options. I think this works for libs but not for workers, I will mark it as experimental for now.
kylebarron
approved these changes
Jun 30, 2020
belom88
pushed a commit
that referenced
this pull request
Dec 8, 2020
belom88
added a commit
that referenced
this pull request
Dec 8, 2020
* Shapefile (.shp) loader (#812) * [Fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' (#817) * [fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' * assert the rowCount instead of the batchCount * Fix typos (#818) * Return ArrayBuffer, not view from concatenateArrayBuffers (#820) * Add parseInBatches Shapefile method (#821) * Consolidate typing (#825) * core: parseInBatches can now be used with all loaders (#829) * core: truly global loaders and options (#828) * polyfills: Improved stream error handling (#830) * core: loader option util improvements (#833) * tiles: fix request scheduling and loader options (#827) * DBF Loader (#819) * core: options.fetch can now be a function, propagate trough context (#826) * core: loadInBatches (#836) * polyfills: Ensure TextDecoder is actually installed and restore encodings under Node. (#834) * Default dbf loader to windows-1252 (#838) * upgrade gatsby-theme-ocular (#831) * website: Fix new ocular website (#839) * core: loadInBatches can accept multiple files (#837) * shapefile: multifile loading (#823) * Add TarBuilder tests and expose module (#813) * images: export typescript types (#841) * images: improved ImageWriter (#840) * loader-utils: Move Worker utils from core (#842) * shapefile: loading fixes (#844) * v2.2.2-alpha.0 * CHANGELOG * v2.3.0-alpha.2 * gis: Binary to geojson converter (#824) * shapefile: More fixes (#845) * shapefile/gis: integrate binaryToGeoJson (#846) * Shapefile fixes (#847) * v2.3.0-alpha.3 * core: parseInBatches context passing (#849) * core: Reorganize exports (#850) * csv: List options to avoid incorrect warnings (#852) * core: BrowserFileSystem (#851) * gis: Add multipolygon support (#853) * v2.3.0-alpha.4 * [Bug/Enhancement] Pass actual resource so inference can be done via getResouceUrlAndType (#857) * [Bug/Enhancement] Pass actual resource so inference can be done via getResourceUrlAndType * v2.3.0-alpha.5 * perf: prevent iterating through typed array if using SharedArrayBuffer (#859) * mvt: Support binary output format (#860) * mvt: Add result.byteLength (#862) * typescript: Enable strict checking (#861) * build(deps): bump lodash from 4.17.15 to 4.17.19 (#858) Signed-off-by: dependabot[bot] <support@github.com> * core: selectLoader/selectLoaderSync split (#863) * v2.3.0-alpha.6 * mvt: Fork @mapbox/vector-tile (prep for optimized binary loading) (#864) * polyfills: Automatically decompress .gz files under Node (#866) * core: makeResponse utility to unify handling of various input types (#787) * gis loaders: Binary geospatial support via options.gis.format (#867) * las: upgrade the laz-perf script to the last version (#869) * compression: New module (#870) * shapefile: add mime types (#872) * Shapefile: Make polyline data type explicit (#873) * crypto: New module for cryptographic hashing (#874) * Multipolygon parsing in binary-to-geojson conversion (#848) * v2.3.0-alpha.7 * Fix name of indices returned from SHPLoader (#875) * crypto: fixes and cleanup (#876) * Use template contributing.md (#753) * Docs: contributing.md cleanup (#878) * flatgeobuf: New module for flatgeobuf format (#880) Co-authored-by: Kyle Barron <barronk@mit.edu> * Remove duplicate shapefile worker loader files (#881) * crypto: Add crc32c transform (#882) * v2.3.0-alpha.8 * core: `parseInBatches` support for `options.transforms` (#883) * pcd: Fix color = 0 after loading (#886) * crypto: fix transform iterators (#887) * pcd: color and normal attribute fixes (#888) * bump ocular-dev-tools: no generator transpile in es6 dist (#889) * CI: add cache to .travis.yml (#890) * CI: fix cache (#891) * v2.3.0-alpha.9 * [Bug] Fix incorrect text/json mimeType (#892) * typescript updates (#893) * 3d-tiles: typescript (#894) * typescript: enable math module (#895) * typescript: gltf (#897) * Use namespace for node imports (#896) Co-authored-by: Ib Green <ib@unfolded.ai> * v2.3.0-alpha.10 * shapefile: detect magic number (#899) * website: Bump deck.gl@8.2.5 (#900) * shapefile: streaming (#901) * shapefile: refactor DBF parser (#903) * loader-utils: concatenateChunksAsync perf increase (#905) * polyfills: Blob/File/FileReader polyfills (#907) * basis: Add CompressedTextureWriter (#909) * Reprojection wrappers for binary and geojson (#906) * v2.3.0-alpha.11 * cli: fixes es-lint errors * Fixes failing tests after merge * Include tsc in pre commit hook (#914) * Shapefile: shp/dbf state parser (#913) Co-authored-by: Ib Green <ib@unfolded.ai> * shapefile: doc improvements (#917) * gltf: partial support for GLBv1 and glTFv1 (#912) * cli: update package dependencies * shapefile: sync converter with master * json, loader-utils: sync converter with master Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Wesam Manassra <wesam.manassra@gmail.com> Co-authored-by: Robert Wettstädt <robert.wett@gmail.com> Co-authored-by: Ib Green <ib@unfolded.ai> Co-authored-by: Xintong Xia <xintong@uber.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com> Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Berthet <berthet.a@gmail.com> Co-authored-by: Kyle Barron <barronk@mit.edu> Co-authored-by: namndtth <42760423+namndtth@users.noreply.github.com> Co-authored-by: Kyle Barron <kyle@unfolded.ai>
belom88
added a commit
that referenced
this pull request
Dec 8, 2020
* Shapefile (.shp) loader (#812) * [Fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' (#817) * [fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' * assert the rowCount instead of the batchCount * Fix typos (#818) * Return ArrayBuffer, not view from concatenateArrayBuffers (#820) * Add parseInBatches Shapefile method (#821) * Consolidate typing (#825) * core: parseInBatches can now be used with all loaders (#829) * core: truly global loaders and options (#828) * polyfills: Improved stream error handling (#830) * core: loader option util improvements (#833) * tiles: fix request scheduling and loader options (#827) * DBF Loader (#819) * core: options.fetch can now be a function, propagate trough context (#826) * core: loadInBatches (#836) * polyfills: Ensure TextDecoder is actually installed and restore encodings under Node. (#834) * Default dbf loader to windows-1252 (#838) * upgrade gatsby-theme-ocular (#831) * website: Fix new ocular website (#839) * core: loadInBatches can accept multiple files (#837) * shapefile: multifile loading (#823) * Add TarBuilder tests and expose module (#813) * images: export typescript types (#841) * images: improved ImageWriter (#840) * loader-utils: Move Worker utils from core (#842) * shapefile: loading fixes (#844) * v2.2.2-alpha.0 * CHANGELOG * v2.3.0-alpha.2 * gis: Binary to geojson converter (#824) * shapefile: More fixes (#845) * shapefile/gis: integrate binaryToGeoJson (#846) * Shapefile fixes (#847) * v2.3.0-alpha.3 * core: parseInBatches context passing (#849) * core: Reorganize exports (#850) * csv: List options to avoid incorrect warnings (#852) * core: BrowserFileSystem (#851) * gis: Add multipolygon support (#853) * v2.3.0-alpha.4 * [Bug/Enhancement] Pass actual resource so inference can be done via getResouceUrlAndType (#857) * [Bug/Enhancement] Pass actual resource so inference can be done via getResourceUrlAndType * v2.3.0-alpha.5 * perf: prevent iterating through typed array if using SharedArrayBuffer (#859) * mvt: Support binary output format (#860) * mvt: Add result.byteLength (#862) * typescript: Enable strict checking (#861) * build(deps): bump lodash from 4.17.15 to 4.17.19 (#858) Signed-off-by: dependabot[bot] <support@github.com> * core: selectLoader/selectLoaderSync split (#863) * v2.3.0-alpha.6 * mvt: Fork @mapbox/vector-tile (prep for optimized binary loading) (#864) * polyfills: Automatically decompress .gz files under Node (#866) * core: makeResponse utility to unify handling of various input types (#787) * gis loaders: Binary geospatial support via options.gis.format (#867) * las: upgrade the laz-perf script to the last version (#869) * compression: New module (#870) * shapefile: add mime types (#872) * Shapefile: Make polyline data type explicit (#873) * crypto: New module for cryptographic hashing (#874) * Multipolygon parsing in binary-to-geojson conversion (#848) * v2.3.0-alpha.7 * Fix name of indices returned from SHPLoader (#875) * crypto: fixes and cleanup (#876) * Use template contributing.md (#753) * Docs: contributing.md cleanup (#878) * flatgeobuf: New module for flatgeobuf format (#880) Co-authored-by: Kyle Barron <barronk@mit.edu> * Remove duplicate shapefile worker loader files (#881) * crypto: Add crc32c transform (#882) * v2.3.0-alpha.8 * core: `parseInBatches` support for `options.transforms` (#883) * pcd: Fix color = 0 after loading (#886) * crypto: fix transform iterators (#887) * pcd: color and normal attribute fixes (#888) * bump ocular-dev-tools: no generator transpile in es6 dist (#889) * CI: add cache to .travis.yml (#890) * CI: fix cache (#891) * v2.3.0-alpha.9 * [Bug] Fix incorrect text/json mimeType (#892) * typescript updates (#893) * 3d-tiles: typescript (#894) * typescript: enable math module (#895) * typescript: gltf (#897) * Use namespace for node imports (#896) Co-authored-by: Ib Green <ib@unfolded.ai> * v2.3.0-alpha.10 * shapefile: detect magic number (#899) * website: Bump deck.gl@8.2.5 (#900) * shapefile: streaming (#901) * shapefile: refactor DBF parser (#903) * loader-utils: concatenateChunksAsync perf increase (#905) * polyfills: Blob/File/FileReader polyfills (#907) * basis: Add CompressedTextureWriter (#909) * Reprojection wrappers for binary and geojson (#906) * v2.3.0-alpha.11 * Include tsc in pre commit hook (#914) * Shapefile: shp/dbf state parser (#913) Co-authored-by: Ib Green <ib@unfolded.ai> * shapefile: doc improvements (#917) * gltf: partial support for GLBv1 and glTFv1 (#912) * Binary to GeoJson fix for individual geometries (#919) * Crypto doc correction (#920) * compression: Support streaming (#871) * shapefile: rename files (#922) * shapefile: cleanup (#923) * Coerce each chunk of a Node stream to an ArrayBuffer (#928) * table: Add arrow-compatible types (#924) * Coerce web stream from Uint8Array to ArrayBuffer (#929) * Shapefile: parse in batches (#925) Co-authored-by: Ib Green <ib@unfolded.ai> * las: parse two-bytes colors (#927) * pcd: Add schema (#930) * obj: Add schema (#933) * build(deps): bump bl from 4.0.2 to 4.0.3 (#934) Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reproject shapefile (#932) * v2.3.0-alpha.12 * Shapefile: types (#931) Co-authored-by: Ib Green <ib@unfolded.ai> * las: add a safeguard for two bytes color detection (#935) * Streaming shapefile fixes (#937) * build(deps): bump node-fetch from 2.6.0 to 2.6.1 (#938) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for extraAttributes in DracoLoader, use them in Tiles3DLoader according to batchTablePropeties (#940) * Add support for extraAttribute in DracoLoader, use them in Tiles3DLoader by reading Cesium's batchTableProperties * Nest the `extraAttributes` option inside the `draco` namespace. * draco: Add draco3d types (#941) * gltf: parseGLBV1 function fixed (#943) * draco: Custom attributes (#942) * Fix docs link (#945) * draco: fixes draco3d memory leak (#944) * 3d-tiles: fixes merge mistake * 3d-tiles: fixes merge mistake Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Wesam Manassra <wesam.manassra@gmail.com> Co-authored-by: Robert Wettstädt <robert.wett@gmail.com> Co-authored-by: Ib Green <ib@unfolded.ai> Co-authored-by: Xintong Xia <xintong@uber.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com> Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Berthet <berthet.a@gmail.com> Co-authored-by: Kyle Barron <barronk@mit.edu> Co-authored-by: namndtth <42760423+namndtth@users.noreply.github.com> Co-authored-by: Kyle Barron <kyle@unfolded.ai> Co-authored-by: Adrien Berthet <adrien.berthet@ign.fr> Co-authored-by: Avnerus <avnerus@gmail.com> Co-authored-by: Vasiliy <vdunaev@users.noreply.github.com>
belom88
added a commit
that referenced
this pull request
Dec 8, 2020
* cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * cli: slpk add md5 hash file * slpk md5 hash (#86) * Tidy up commands online help (#72) * Tidy up commands online help * Fixed comments * Removed draco param * Fixed shared resources (#77) * cli, draco: fixes converter bundle (#66) * cli, draco: fixes converter bundle * cli: slpk - zip via child_process * cli: slpk - zip via child_process * cli: i3s feature 0 conversion * cli: fixes null mbs radius issue * cli: 7z compress util for Windows * cli: 7z compress util for Windows * cli: zip via child_process fixes PR comments * cli: i3s converter add feature 0 fixes PR comments * draco: get encoder from globalState * cli: import draco libs from draco3d * cli, draco: fixes converter bundle * draco: fixes draco3d memory leak * draco: fixes draco3d memory leak * cli: fixes typo * Added conversion statistic (#75) * Added conversion statistic * Fixed comments * Fixed comments related to type * Changed conversion time logic * Converter sync with master (#80) * Shapefile (.shp) loader (#812) * [Fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' (#817) * [fix] Pass through 'dynamicTyping' to the parser in 'parseInBatches' * assert the rowCount instead of the batchCount * Fix typos (#818) * Return ArrayBuffer, not view from concatenateArrayBuffers (#820) * Add parseInBatches Shapefile method (#821) * Consolidate typing (#825) * core: parseInBatches can now be used with all loaders (#829) * core: truly global loaders and options (#828) * polyfills: Improved stream error handling (#830) * core: loader option util improvements (#833) * tiles: fix request scheduling and loader options (#827) * DBF Loader (#819) * core: options.fetch can now be a function, propagate trough context (#826) * core: loadInBatches (#836) * polyfills: Ensure TextDecoder is actually installed and restore encodings under Node. (#834) * Default dbf loader to windows-1252 (#838) * upgrade gatsby-theme-ocular (#831) * website: Fix new ocular website (#839) * core: loadInBatches can accept multiple files (#837) * shapefile: multifile loading (#823) * Add TarBuilder tests and expose module (#813) * images: export typescript types (#841) * images: improved ImageWriter (#840) * loader-utils: Move Worker utils from core (#842) * shapefile: loading fixes (#844) * v2.2.2-alpha.0 * CHANGELOG * v2.3.0-alpha.2 * gis: Binary to geojson converter (#824) * shapefile: More fixes (#845) * shapefile/gis: integrate binaryToGeoJson (#846) * Shapefile fixes (#847) * v2.3.0-alpha.3 * core: parseInBatches context passing (#849) * core: Reorganize exports (#850) * csv: List options to avoid incorrect warnings (#852) * core: BrowserFileSystem (#851) * gis: Add multipolygon support (#853) * v2.3.0-alpha.4 * [Bug/Enhancement] Pass actual resource so inference can be done via getResouceUrlAndType (#857) * [Bug/Enhancement] Pass actual resource so inference can be done via getResourceUrlAndType * v2.3.0-alpha.5 * perf: prevent iterating through typed array if using SharedArrayBuffer (#859) * mvt: Support binary output format (#860) * mvt: Add result.byteLength (#862) * typescript: Enable strict checking (#861) * build(deps): bump lodash from 4.17.15 to 4.17.19 (#858) Signed-off-by: dependabot[bot] <support@github.com> * core: selectLoader/selectLoaderSync split (#863) * v2.3.0-alpha.6 * mvt: Fork @mapbox/vector-tile (prep for optimized binary loading) (#864) * polyfills: Automatically decompress .gz files under Node (#866) * core: makeResponse utility to unify handling of various input types (#787) * gis loaders: Binary geospatial support via options.gis.format (#867) * las: upgrade the laz-perf script to the last version (#869) * compression: New module (#870) * shapefile: add mime types (#872) * Shapefile: Make polyline data type explicit (#873) * crypto: New module for cryptographic hashing (#874) * Multipolygon parsing in binary-to-geojson conversion (#848) * v2.3.0-alpha.7 * Fix name of indices returned from SHPLoader (#875) * crypto: fixes and cleanup (#876) * Use template contributing.md (#753) * Docs: contributing.md cleanup (#878) * flatgeobuf: New module for flatgeobuf format (#880) Co-authored-by: Kyle Barron <barronk@mit.edu> * Remove duplicate shapefile worker loader files (#881) * crypto: Add crc32c transform (#882) * v2.3.0-alpha.8 * core: `parseInBatches` support for `options.transforms` (#883) * pcd: Fix color = 0 after loading (#886) * crypto: fix transform iterators (#887) * pcd: color and normal attribute fixes (#888) * bump ocular-dev-tools: no generator transpile in es6 dist (#889) * CI: add cache to .travis.yml (#890) * CI: fix cache (#891) * v2.3.0-alpha.9 * [Bug] Fix incorrect text/json mimeType (#892) * typescript updates (#893) * 3d-tiles: typescript (#894) * typescript: enable math module (#895) * typescript: gltf (#897) * Use namespace for node imports (#896) Co-authored-by: Ib Green <ib@unfolded.ai> * v2.3.0-alpha.10 * shapefile: detect magic number (#899) * website: Bump deck.gl@8.2.5 (#900) * shapefile: streaming (#901) * shapefile: refactor DBF parser (#903) * loader-utils: concatenateChunksAsync perf increase (#905) * polyfills: Blob/File/FileReader polyfills (#907) * basis: Add CompressedTextureWriter (#909) * Reprojection wrappers for binary and geojson (#906) * v2.3.0-alpha.11 * Include tsc in pre commit hook (#914) * Shapefile: shp/dbf state parser (#913) Co-authored-by: Ib Green <ib@unfolded.ai> * shapefile: doc improvements (#917) * gltf: partial support for GLBv1 and glTFv1 (#912) * Binary to GeoJson fix for individual geometries (#919) * Crypto doc correction (#920) * compression: Support streaming (#871) * shapefile: rename files (#922) * shapefile: cleanup (#923) * Coerce each chunk of a Node stream to an ArrayBuffer (#928) * table: Add arrow-compatible types (#924) * Coerce web stream from Uint8Array to ArrayBuffer (#929) * Shapefile: parse in batches (#925) Co-authored-by: Ib Green <ib@unfolded.ai> * las: parse two-bytes colors (#927) * pcd: Add schema (#930) * obj: Add schema (#933) * build(deps): bump bl from 4.0.2 to 4.0.3 (#934) Bumps [bl](https://github.com/rvagg/bl) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v4.0.2...v4.0.3) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Reproject shapefile (#932) * v2.3.0-alpha.12 * Shapefile: types (#931) Co-authored-by: Ib Green <ib@unfolded.ai> * las: add a safeguard for two bytes color detection (#935) * Streaming shapefile fixes (#937) * build(deps): bump node-fetch from 2.6.0 to 2.6.1 (#938) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add support for extraAttributes in DracoLoader, use them in Tiles3DLoader according to batchTablePropeties (#940) * Add support for extraAttribute in DracoLoader, use them in Tiles3DLoader by reading Cesium's batchTableProperties * Nest the `extraAttributes` option inside the `draco` namespace. * draco: Add draco3d types (#941) * gltf: parseGLBV1 function fixed (#943) * draco: Custom attributes (#942) * Fix docs link (#945) * draco: fixes draco3d memory leak (#944) * 3d-tiles: fixes merge mistake * 3d-tiles: fixes merge mistake Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Wesam Manassra <wesam.manassra@gmail.com> Co-authored-by: Robert Wettstädt <robert.wett@gmail.com> Co-authored-by: Ib Green <ib@unfolded.ai> Co-authored-by: Xintong Xia <xintong@uber.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com> Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Berthet <berthet.a@gmail.com> Co-authored-by: Kyle Barron <barronk@mit.edu> Co-authored-by: namndtth <42760423+namndtth@users.noreply.github.com> Co-authored-by: Kyle Barron <kyle@unfolded.ai> Co-authored-by: Adrien Berthet <adrien.berthet@ign.fr> Co-authored-by: Avnerus <avnerus@gmail.com> Co-authored-by: Vasiliy <vdunaev@users.noreply.github.com> * Added .vscode folder to gitignore (#79) * 3d tiles converter skeleton (#81) * cli: 3dtiles converter skeleton * cli: 3dtiles converter skeleton - fixes PR comments * cli: slpk md5 hash - fixes merge confilict Co-authored-by: Daniil Ryabinin <70207219+dryabinin-actionengine@users.noreply.github.com> Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Wesam Manassra <wesam.manassra@gmail.com> Co-authored-by: Robert Wettstädt <robert.wett@gmail.com> Co-authored-by: Ib Green <ib@unfolded.ai> Co-authored-by: Xintong Xia <xintong@uber.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com> Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Berthet <berthet.a@gmail.com> Co-authored-by: Kyle Barron <barronk@mit.edu> Co-authored-by: namndtth <42760423+namndtth@users.noreply.github.com> Co-authored-by: Kyle Barron <kyle@unfolded.ai> Co-authored-by: Adrien Berthet <adrien.berthet@ign.fr> Co-authored-by: Avnerus <avnerus@gmail.com> Co-authored-by: Vasiliy <vdunaev@users.noreply.github.com> Co-authored-by: Alexey Vasyankin <alexey.vasyankin@actionengine.com> Co-authored-by: Victor Belomestnov <belom88@yandex.ru> Co-authored-by: Daniil Ryabinin <70207219+dryabinin-actionengine@users.noreply.github.com> Co-authored-by: Kyle Barron <kylebarron2@gmail.com> Co-authored-by: Wesam Manassra <wesam.manassra@gmail.com> Co-authored-by: Robert Wettstädt <robert.wett@gmail.com> Co-authored-by: Ib Green <ib@unfolded.ai> Co-authored-by: Xintong Xia <xintong@uber.com> Co-authored-by: Xiaoji Chen <Pessimistress@users.noreply.github.com> Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Adrien Berthet <berthet.a@gmail.com> Co-authored-by: Kyle Barron <barronk@mit.edu> Co-authored-by: namndtth <42760423+namndtth@users.noreply.github.com> Co-authored-by: Kyle Barron <kyle@unfolded.ai> Co-authored-by: Adrien Berthet <adrien.berthet@ign.fr> Co-authored-by: Avnerus <avnerus@gmail.com> Co-authored-by: Vasiliy <vdunaev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a continuation of the option improvements from the fetch PR: #826 .
Landing these and rebasing should clean up that PR and allow for a more confident review of sensitive changes.
This PR extends options checking against all registered/provided loader objects, with hints if partial matches and now also checks the root object for deprecated props (will be used in fetch PR)