add comments

visgl · Mar 17, 2024 · 18bb2c8 · 18bb2c8
1 parent 51a4b8a
commit 18bb2c8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/modules/webgl/src/adapter/resources/webgl-command-buffer.ts b/modules/webgl/src/adapter/resources/webgl-command-buffer.ts
@@ -183,6 +183,7 @@ function _copyTextureToBuffer(device: WebGLDevice, options: CopyTextureToBufferO
     );
   } finally {
     device.gl.bindBuffer(GL.PIXEL_PACK_BUFFER, null);
+    // prevHandle may be unassigned if the try block failed before binding
     if (prevHandle !== undefined) {
       device.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle);
     }

diff --git a/modules/webgl/src/adapter/resources/webgl-framebuffer.ts b/modules/webgl/src/adapter/resources/webgl-framebuffer.ts
@@ -40,7 +40,7 @@ export class WEBGLFramebuffer extends Framebuffer {
       this.autoCreateAttachmentTextures();
 
       /** Attach from a map of attachments */
-      // @ts-expect-error
+      // @ts-expect-error native bindFramebuffer is overridden by our state tracker
       const prevHandle: WebGLFramebuffer | null = this.gl.bindFramebuffer(
         GL.FRAMEBUFFER,
         this.handle