Remove onContext callbacks

Signed-off-by: Chris Gervang <chris@gervang.com>
visgl · Jun 20, 2024 · 688f87f · 688f87f
1 parent f5f8072
commit 688f87f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/docs/api-reference/core/device.md b/docs/api-reference/core/device.md
@@ -79,8 +79,6 @@ Extends `DeviceProps`.
 | `powerPreference`               | `'high-performance'`| `'default'`, `'high-performance'`, `'low-power'`                                                                         |
 | `premultipliedAlpha?`           | `true`             | Boolean that indicates that the page compositor will assume the drawing buffer contains colors with pre-multiplied alpha. |
 | `preserveDrawingBuffer?`        | `false`            | Default render target buffers will preserve their values until cleared or overwritten. Useful for screen capture.         |
-| `onContextLost`                 | `(event: Event) => void` | `webglcontextlost` event.                                                                                           |
-| `onContextRestored`             | `(event: Event) => void` | `webglcontextrestored` event.                                                                                       |
 | `debug?: boolean`               | `false`            | WebGL API calls will be logged to the console and WebGL errors will generate JavaScript exceptions.                       |
 | `break?: string[]`              | `[]`               | Insert a break point (`debugger`) if one of the listed gl functions is called.                                            |
 | `manageState?: boolean`         | `true`             | Set to false to disable WebGL state management instrumentation.                                                           |

diff --git a/modules/core/src/adapter/device.ts b/modules/core/src/adapter/device.ts
@@ -231,8 +231,6 @@ export type WebGLDeviceProps = _DeviceProps & {
   spectorUrl?: string;
 
   // ContextProps
-  onContextLost?: (event: Event) => void;
-  onContextRestored?: (event: Event) => void;
   alpha?: boolean; // indicates if the canvas contains an alpha buffer.
   depth?: boolean; // indicates that the drawing buffer has a depth buffer of at least 16 bits.
   stencil?: boolean; // Default render target has a stencil buffer of at least `8` bits.
@@ -304,9 +302,6 @@ export abstract class Device {
     premultipliedAlpha: true,
     preserveDrawingBuffer: false,
 
-    onContextLost: undefined!,
-    onContextRestored: undefined!,
-
     debug: Boolean(log.get('debug')), // Instrument context (at the expense of performance)
     break: (log.get('break') as string[]) || [],
 

diff --git a/modules/webgl/src/adapter/webgl-device.ts b/modules/webgl/src/adapter/webgl-device.ts
@@ -128,13 +128,11 @@ export class WebGLDevice extends Device {
 
     this.handle = createBrowserContext(this.canvasContext.canvas, {
       ...props,
-      onContextLost: (event: Event) => {
+      onContextLost: (event: Event) =>
         this._resolveContextLost?.({
           reason: 'destroyed',
           message: 'Entered sleep mode, or too many apps or browser tabs are using the GPU.'
-        });
-        props.onContextLost?.(event);
-      }
+        })
     });
     this.gl = this.handle;