Make sure animationLoop's onError catches context creation errors (#1419

)
visgl · Dec 8, 2020 · e03ef9c · e03ef9c
1 parent 18d75a2
commit e03ef9c
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/modules/gltools/src/context/context.js b/modules/gltools/src/context/context.js
@@ -176,7 +176,8 @@ function createBrowserContext(canvas, options) {
   const {onError} = options;
 
   // Try to extract any extra information about why context creation failed
-  const onCreateError = error => onError(`WebGL context: ${error.statusMessage || 'error'}`);
+  let errorMessage = null;
+  const onCreateError = error => (errorMessage = error.statusMessage || errorMessage);
   canvas.addEventListener('webglcontextcreationerror', onCreateError, false);
 
   const {webgl1 = true, webgl2 = true} = options;
@@ -194,7 +195,10 @@ function createBrowserContext(canvas, options) {
   canvas.removeEventListener('webglcontextcreationerror', onCreateError, false);
 
   if (!gl) {
-    return onError(`Failed to create ${webgl2 && !webgl1 ? 'WebGL2' : 'WebGL'} context`);
+    return onError(
+      `Failed to create ${webgl2 && !webgl1 ? 'WebGL2' : 'WebGL'} context: ${errorMessage ||
+        'Unknown error'}`
+    );
   }
 
   return gl;