Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform: Fix update of Buffers and elementCount. #1224

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Transform: Fix update of Buffers and elementCount. #1224

merged 2 commits into from
Sep 5, 2019

Conversation

1chandu
Copy link
Contributor

@1chandu 1chandu commented Aug 29, 2019

Fixes #1218

Background

  • Move all Buffer setting code to _setBuffers, that is used during construction and update, this allows Transform to be constructed without any Buffers and they be set later using update.
  • Fix elementCount update, so Transform can be constructed without specifying it. It must be provided before calling run.

Change List

  • Transform: Fix update of Buffers and elementCount.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 62.696% when pulling 0e25357 on TransformUpdateFix into 2b94e23 on master.

@1chandu 1chandu merged commit 0c58560 into master Sep 5, 2019
@1chandu 1chandu deleted the TransformUpdateFix branch September 5, 2019 21:23
1chandu added a commit that referenced this pull request Sep 7, 2019
@1chandu
Port #1224
423cfbc
1chandu added a commit that referenced this pull request Sep 9, 2019
@1chandu
Port #1224
eda3c9d
tgorkin added a commit that referenced this pull request Sep 11, 2019
@tgorkin
Merge branch 'master' into tgorkin/gatsby-upgrade-1.0
ad05d1f 
* master:
  Transform refactor (#1221)
  dev-tools: Bump to 0.0.29 (#1232)
  v7.3.0-alpha.7
  Transform: Fix update of Buffers and elementCount. (#1224)
  point docs to release branch (#1229)
  update website fonts (#1227)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

@tsherif tsherif Awaiting requested review from tsherif

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transform: update should handle Buffer and elementCount udpated
3 participants
@1chandu @coveralls @Pessimistress