Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shader module tutorial and example #1308

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Shader module tutorial and example #1308

merged 3 commits into from
Dec 7, 2019

Conversation

tsherif
Copy link
Contributor

@tsherif tsherif commented Dec 6, 2019

No description provided.

@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited
Loading

Coverage Status

Coverage increased (+3.9%) to 65.635% when pulling 8066f93 on shader-module-tutorial into 2f2a17d on master.

Pessimistress
Pessimistress reviewed Dec 6, 2019
View reviewed changes
docs/get-started/shader-modules.md Outdated
const colorModule = {
name: "color",
fs: `
vec4 color_getColor() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should we show something more useful here, e.g. HSL to RGB?

@tsherif tsherif merged commit f4e15f1 into master Dec 7, 2019
@Pessimistress Pessimistress deleted the shader-module-tutorial branch July 19, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Pessimistress approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsherif @coveralls @Pessimistress