GPU Accelerated Point In Polygon Test #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1chandu
changed the title
tsherif
reviewed
Feb 14, 2020
modules/experimental/src/gpgpu/point-in-polygon/gpu-point-in-polygon.js
Outdated
Show resolved
Hide resolved
| const curCount = curVertices.length / SIZE; | ||
| const curIds = new Float32Array(curCount).fill(polygonId); | ||
| vertices.push(...curVertices); | ||
| ids.push(...curIds); |
There was a problem hiding this comment.
How big can these arrays get? Would recommend pre-allocating the arrays to avoid re-allocating and they dynamically extend.
There was a problem hiding this comment.
We can add array manager support in the future PRs, that can be independent of this feature and used across all luma modules.
tsherif
approved these changes
Feb 18, 2020
heshan0131
reviewed
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1356
Background
GPUPointInPolygonto perform point-in-polygon test.TextureTransformto be created with source asBuffersandTextureas target. (Shouldn't impact any existing use cases)polygon.js) from deck.gl, we should move this tomath.gleventually to avoid duplication.Change List