add calculate tangents #1389
add calculate tangents #1389
Conversation
| @@ -20,3 +20,4 @@ export {KeyFrames} from './animation/key-frames'; | |||
|
|
|||
| // Utils | |||
| export {default as ClipSpace} from './utils/clip-space'; | |||
| export {calculateTangents} from './utils/tangent'; | |||
There was a problem hiding this comment.
Use and underscore export until we do API audit?
| @@ -0,0 +1,64 @@ | |||
| import {Vector2, Vector3} from 'math.gl'; | |||
There was a problem hiding this comment.
Name file after primary export (calculate-tangents.js)?
| for (let i = 0; i < length; i += 3) { | ||
| const locations = indices ? [indices[i], indices[i + 1], indices[i + 2]] : [i, i + 1, i + 2]; | ||
| const [v0, v1, v2] = locations; | ||
| scratchPos0.set(positions[v0 * 3], positions[v0 * 3 + 1], positions[v0 * 3 + 2]); |
There was a problem hiding this comment.
Would be nice with comments explaining each intermediary value
| const scratchB1 = new Vector3(); | ||
| const scratchB2 = new Vector3(); | ||
|
|
||
| export function calculateTangents(positions, texCoords, indices) { |
There was a problem hiding this comment.
With out looking close, since we are not passing normals, I assume they are calculated from triangles. Would it make sense to pass in normals if we have them (to generate bitangents from crossing tangents and normals)
Since it is easy to calculate bitangents in shader, provide option for only calculating tangents?
| indices | ||
| } = geometry; | ||
|
|
||
| const {tangents, bitangents} = calculateTangents( |
There was a problem hiding this comment.
It would be nice if calculateTangents accepted a luma.gl geometry object (looked for attributes and indices)
| positions: new Buffer( | ||
| gl, | ||
| new Float32Array([ | ||
| 0.0, |
There was a problem hiding this comment.
Use // prettier-ignore to avoid such crazy autoformatting.
| @@ -0,0 +1,22 @@ | |||
| <!doctype html> | |||
There was a problem hiding this comment.
I personally think it is nicer to do these examples with an automatically generated HTML (html-webpack-plugin). But just follow the style of other examples in same repo.
| <html> | ||
| <head> | ||
| <meta charset='UTF-8' /> | ||
| <title>deck.gl w/ Esri ArcGIS API for JavaScript and I3S loader</title> |
For #1387
Background
Change List
TODO