Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call gl.getProgramInfoLog before gl.validateProgram #1396

Merged
merged 1 commit into from Aug 22, 2020

Conversation

unconed
Copy link
Contributor

@unconed unconed commented Aug 22, 2020

For #1395

Change List

  • Call gl.getProgramInfoLog before gl.validateProgram
  • Check link status separately from validate status

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@unconed This looks very good. Happy to land as is, though it would of course always be best to add a test case as well.

I usually try to create a failing test case when I discover an issue, then confirm that a fix makes that test case pass.

Great if you wanted to give it a try, but if too much effort, happy to merge as is.

@unconed
Copy link
Contributor Author

unconed commented Aug 22, 2020

I'm not familiar enough with the testing set up, I'll leave writing a test case for another kind soul.

@ibgreen
Copy link
Collaborator

ibgreen commented Aug 22, 2020

@unconed Fair enough. For what it's worth I think the test case could quite naturally be placed here: https://github.com/visgl/luma.gl/blob/master/modules/webgl/test/classes/program.spec.js#L29

@ibgreen ibgreen merged commit f9ab6a3 into visgl:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants