chore: Address prop-types feedback #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Nov 23, 2022
| type: string; | ||
| value: any; | ||
| max?: number; | ||
| min?: number; | ||
| private?: boolean; | ||
| validate?(value: any, propDef: PropDef): boolean; | ||
| validate?(value: any, propDef: PropValidator): boolean; |
There was a problem hiding this comment.
Suggested change
| validate?(value: any, propDef: PropValidator): boolean; | |
| validate?(value: any, propType: PropType): boolean; |
There was a problem hiding this comment.
The original propType isn't saved so it may not be available.
I moved the validation code into the prop-types file which I think makes things a lot clearer.
I think that is sufficient amount of improvements for this round
ibgreen
force-pushed
the
ib/prop-types
branch
from
b65891d
to
4ffcfca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1619 (comment)
Background
Change List