Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable prettier #1970

Merged
merged 6 commits into from
Feb 26, 2024
Merged

chore: Enable prettier #1970

merged 6 commits into from
Feb 26, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Feb 26, 2024 •
edited
Loading

For #

Background

  • prettier was mostly disabled, enable before we ship v9

Change List

  • Remove prettierrc exceptions

@ibgreen ibgreen marked this pull request as ready for review February 26, 2024 16:53
donmccurdy
donmccurdy approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy if the build is happy (excluding code coverage). Thank you! :)

@ibgreen ibgreen merged commit 8947329 into master Feb 26, 2024
1 of 2 checks passed
@ibgreen ibgreen deleted the ib/prettier branch February 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @donmccurdy