chore(build): size optimization #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
commented
Mar 1, 2024
| @@ -35,6 +35,7 @@ | |||
| ], | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "pre-build": "npx esbuild src/index.ts --bundle --format=cjs --outfile=dist/index.cjs", | |||
There was a problem hiding this comment.
The constants module is a dependency of the inline-webgl-constants TS plugin
There was a problem hiding this comment.
Hmm yes that is messy. Perhaps we can add a "scripts-comments: ["comment1", "comment2",...] section above in package.json so we can explain what is going on. This kind of stuff in build files is not fun for maintainers down the road.
Pessimistress
changed the title
ibgreen
approved these changes
Mar 1, 2024
| @@ -35,6 +35,7 @@ | |||
| ], | |||
| "sideEffects": false, | |||
| "scripts": { | |||
| "pre-build": "npx esbuild src/index.ts --bundle --format=cjs --outfile=dist/index.cjs", | |||
There was a problem hiding this comment.
Hmm yes that is messy. Perhaps we can add a "scripts-comments: ["comment1", "comment2",...] section above in package.json so we can explain what is going on. This kind of stuff in build files is not fun for maintainers down the road.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List
inline-webgl-constantstransformerremove-glsl-commentstransformer