Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): remove splitUniforms() utility & Model.moduleSettings #1999

Closed
wants to merge 1 commit into from
Closed

chore(core): remove splitUniforms() utility & Model.moduleSettings #1999

wants to merge 1 commit into from

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 6, 2024 •
edited

For #2000

Background

  • Concern about size of core module utilities.

Change List

  • Testing a removal of splitUniformsAndBindings()

Result

  • index.cjs (unminified) down from 76.9kb -> 76.5kb (~400 bytes).

@ibgreen ibgreen force-pushed the ib/remove-module-settings branch 2 times, most recently from 30ad228 to 5d73344 Compare March 7, 2024 13:37
@ibgreen
Copy link
Collaborator Author

ibgreen commented Mar 29, 2024

We need to move this function into ShaderInputs instead.

@ibgreen ibgreen closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen