Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Remove assert, cast, stubProps, checkProps, ... #2001

Merged
merged 4 commits into from
Mar 6, 2024
Merged

chore(core): Remove assert, cast, stubProps, checkProps, ... #2001

merged 4 commits into from
Mar 6, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 6, 2024

For #2000

Background

  • Concern about size of core module utilities.

Change List

  • Removal of unused or almost unused generic utils

Result

  • index.cjs (unminified) down from 76.9kb -> 73.4kb (~3.5 kb).

@ibgreen ibgreen marked this pull request as ready for review March 6, 2024 20:43
@ibgreen ibgreen changed the title chhore(core): Remove assert, cast, stubProps, checkProps, ... chore(core): Remove assert, cast, stubProps, checkProps, ... Mar 6, 2024
@ibgreen ibgreen merged commit f3284e1 into master Mar 6, 2024
1 check passed
@ibgreen ibgreen deleted the ib/remove-core-utils branch March 6, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ibgreen