Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move core-tests into core/tests #2010

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Move core-tests into core/tests #2010

merged 2 commits into from
Mar 7, 2024

Conversation

Pessimistress
Copy link
Collaborator

Change List

  • Remove core-tests "module"

@Pessimistress Pessimistress marked this pull request as ready for review March 7, 2024 04:02
ibgreen
ibgreen approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit suspicious as I had big problems making this setup work with tsconfigs etc and I don't really see any key changes that would address that class of problems here. But a quick test on your branch looked good, so let's give a try.

@Pessimistress Pessimistress merged commit a27c2cd into master Mar 7, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/core-tests branch March 7, 2024 16:06
Pessimistress added a commit that referenced this pull request May 10, 2024
@Pessimistress
Move core-tests into core/tests (#2010)
de88b48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pessimistress @ibgreen