Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shadertools: Remove getVersionDefines #2012

Merged
merged 2 commits into from
Mar 7, 2024
Merged

shadertools: Remove getVersionDefines #2012

merged 2 commits into from
Mar 7, 2024

Conversation

felixpalmer
Copy link
Collaborator

Fixes regression from #1962 that broke https://felixpalmer.github.io/deck.gl/examples/google-maps

Change List

  • Fix comma used in for loops
  • Remove getVersionDefines and related checks in shaders

@felixpalmer felixpalmer requested a review from ibgreen March 7, 2024 16:38
@felixpalmer felixpalmer mentioned this pull request Mar 7, 2024
Closed
ibgreen
ibgreen approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and apologies for the regression.

@ibgreen ibgreen merged commit 2ea2b01 into master Mar 7, 2024
2 checks passed
@ibgreen ibgreen deleted the felix/smart-for-regression branch March 7, 2024 21:09
felixpalmer added a commit that referenced this pull request Mar 8, 2024
@felixpalmer
shadertools: Remove getVersionDefines (#2012)
c801d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felixpalmer @ibgreen