fix(webgl): unbind buffer after setting attribute #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Mar 13, 2024
| @@ -97,6 +97,9 @@ export class WEBGLVertexArray extends VertexArray { | |||
| // Attaches ARRAY_BUFFER with specified buffer format to location | |||
| this.device.gl.vertexAttribPointer(location, size, type, normalized, stride, offset); | |||
| } | |||
| // Clear binding - keeping it may cause [.WebGL-0x12804417100] | |||
| // GL_INVALID_OPERATION: A transform feedback buffer that would be written to is also bound to a non-transform-feedback target | |||
| this.device.gl.bindBuffer(GL.ARRAY_BUFFER, null); | |||
There was a problem hiding this comment.
It makes for a noisier gl log but seems hard to drop this without side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments
Change List