Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): Remove webgl-only topologies (9.1) #2028

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore(core): Remove webgl-only topologies (9.1) #2028

merged 1 commit into from
Mar 13, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 13, 2024 •
edited
Loading

For #

Background

  • WebGPU is more restrictive than WebGL in which topologies (WebGL draw modes) it supports.
  • Warnings have been present announcing that the two WebGL-only topologies (triangle-fan-webgl and line-loop-webgl ) will be removed in 9.1
  • deck.gl 9.1 is going to have to update its triangle-fan geometries to run on WebGPU anyways, so there is not much point in keeping these around.

Change List

  • Remove support for triangle-fan-webgl and line-loop-webgl topologies.

@ibgreen ibgreen marked this pull request as ready for review March 13, 2024 12:20
donmccurdy
donmccurdy approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifies things, thanks! 🧹🧼

@ibgreen ibgreen merged commit c5c15fb into master Mar 13, 2024
2 checks passed
@ibgreen ibgreen deleted the ib/remove-deprecated-topologies branch March 13, 2024 17:47
@ibgreen ibgreen mentioned this pull request Jun 25, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

@Pessimistress Pessimistress Awaiting requested review from Pessimistress

@felixpalmer felixpalmer Awaiting requested review from felixpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibgreen @donmccurdy